Fix GetEntry / MLST for servers which send multiple spaces #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers seem to send multiple spaces at the end of an MLST response.
MLST Workspace
250-Listing Workspace
size=0;type=dir;perm=rwx;modify=20250218125218; /Workspace
250 End
Before this change this would cause the GetEntry method to return this
error.
unsupported LIST line
This patch ignores zero or more spaces at the start of the MLST response.
ncw
force-pushed
the
fix-MLST-multiple-spaces
branch
from
4be4335 to
1fa62b3
Compare
Contributor
Author
|
Not sure why it says "This branch must not contain merge commits." there are no merge commits in the branch. The CodeQL tests have failed for what must be an unrelated reason "Error: Cannot read properties of undefined (reading 'length')". The unit tests have blown up too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers seem to send multiple spaces at the end of an MLST response.
Before this change this would cause the GetEntry method to return this
error.
This patch ignores zero or more spaces at the start of the MLST response.
This was originally discovered in rclone/rclone#8403