cli: add is_terminal_output() to templating language
#7688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for omitting OSC escape codes in templates; #7592 Signed-off-by: Austin Seipp <[email protected]>
|
I don't particularly love the name, btw. Maybe |
yuja
reviewed
Oct 10, 2025
| "is_terminal_output", | ||
| |_language, _diagnostics, _build_ctx, function| { | ||
| function.expect_no_arguments()?; | ||
| let is_terminal = io::stdout().is_terminal(); |
There was a problem hiding this comment.
Since template output may be written into file (when rendering commit description template for example), we should test if the output stream/formatter is terminal (or colored.) However, the templater doesn't know about the output stream. Maybe we can inject is_terminal context variable by TemplateRenderer, but I don't know how many terminal-related flags should be provided. Currently, there's just colored or not.
Another option is to rename this function to something like is_stdout_terminal to clarify that it is useless when rendering description templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for omitting OSC escape codes in templates; #7592
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)