bookmarks: Make target revision a required argument to create/move/set #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drieber
force-pushed
the
push-vqwusvyuutsl
branch
2 times, most recently
from
aff9a32 to
b4610d5
Compare
drieber
force-pushed
the
push-vqwusvyuutsl
branch
from
b4610d5 to
0a590d7
Compare
|
Should we make this a soft deprecation in the next version and a hard error in the subsequent version? It seems like it might break real interactive and non-interactive workflows in a frustrating way. It looks like the hard work of migrating all the tests is already done, so hopefully it's a small additional change? |
yes, that should be done and actually deprecated after 6 releases, like the rest of the user-visible command changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is not backwards compatible, but it should be very easy to adapt to it.
This fixes
#5374
See also
#5363
Checklist
If applicable:
CHANGELOG.md