Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: git push: allow signing commits on push #5164

Merged
merged 1 commit into from
Jan 12, 2025
Merged

cli: git push: allow signing commits on push #5164

merged 1 commit into from
Jan 12, 2025

Conversation

bnjmnt4n
Copy link
Member

@bnjmnt4n bnjmnt4n commented Dec 20, 2024 •
edited
Loading

This adds the git.sign-on-push configuration which can be used to
automatically sign unsigned commits before pushing to a Git remote.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@bnjmnt4n bnjmnt4n mentioned this pull request Dec 20, 2024
Open
@bnjmnt4n bnjmnt4n changed the title cli: git: allow signing commits on push cli: git push: allow signing commits on push Dec 21, 2024
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-qqwqrnzynrru branch from d4d3183 to 9d668dd Compare December 27, 2024 18:50
@pylbrecht
Copy link
Contributor

pylbrecht commented Jan 2, 2025 •
edited
Loading

Heads-up: with #4853 hopefully soon to be merged, you may have a conflict-inducing rebase ahead.

We removed builtin_sig_detailed and only kept templating primitives for signatures (see #4853 (comment)). This means you will have to write your own template in cli/tests/test_git_push.rs to assert against signature presence.

@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-qqwqrnzynrru branch from 9d668dd to db57a23 Compare January 4, 2025 12:38
@bnjmnt4n bnjmnt4n marked this pull request as ready for review January 4, 2025 12:38
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-qqwqrnzynrru branch 2 times, most recently from 8ccb704 to 9f848b6 Compare January 9, 2025 11:59
martinvonz
martinvonz reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Signing is really slow for me so I'm looking forward to this feature

cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-qqwqrnzynrru branch from 9f848b6 to 25d79b6 Compare January 10, 2025 10:58
bnjmnt4n
bnjmnt4n commented Jan 10, 2025
View reviewed changes
Copy link
Member Author

@bnjmnt4n bnjmnt4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to address most of the comments.

cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-qqwqrnzynrru branch from 25d79b6 to 8382125 Compare January 10, 2025 11:28
yuja
yuja reviewed Jan 10, 2025
View reviewed changes
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
martinvonz
martinvonz reviewed Jan 10, 2025
View reviewed changes
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-qqwqrnzynrru branch from 8382125 to 74633a3 Compare January 11, 2025 13:44
martinvonz
martinvonz approved these changes Jan 12, 2025
View reviewed changes
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
@bnjmnt4n
cli: git push: allow signing commits on push
3af0723 
This adds the `git.sign-on-push` configuration which can be used to
automatically sign unsigned commits before pushing to a Git remote.
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-qqwqrnzynrru branch from 74633a3 to 3af0723 Compare January 12, 2025 02:08
@bnjmnt4n bnjmnt4n added this pull request to the merge queue Jan 12, 2025
Merged via the queue into main with commit 9aaf983 Jan 12, 2025
35 checks passed
@bnjmnt4n bnjmnt4n deleted the bnjmnt4n/push-qqwqrnzynrru branch January 12, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

@yuja yuja yuja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnjmnt4n @pylbrecht @yuja @martinvonz