feat(ScreenObtainer) add fallback option for Electron #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the enclosing Jitsi Meet app declares gDM in Electron is supported, ignore the `electronUseGetDisplayMedia` config flag and use the gDM flow. This facilitates having backwards compatibility since the Electron app won't know if the deployment it's about to join has the gDM flow support or not.
- Lower logger level to warning - Use nested conditions
jallamsetty1
approved these changes
Feb 6, 2025
| if (typeof window.JitsiMeetScreenObtainer?.openDesktopPicker === 'function') { | ||
| // Detect if we have the fallback option. | ||
| if (window.JitsiMeetScreenObtainer?.gDMSupported) { | ||
| return this.obtainScreenFromGetDisplayMedia(onSuccess, onFailure); |
There was a problem hiding this comment.
I just remembered that we apply the min fps constraint on the stream returned by obtainScreenFromGetDisplayMedia so that the 0 Hz mode for SS doesn't kick in automatically for browser. Do you think we need to run that on Electron clients as well? I am not sure if that will cause any issues in Electron though.
There was a problem hiding this comment.
I'd expect not to cause issues since it will be the same code path than for chrome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the enclosing Jitsi Meet app declares gDM in Electron is supported, ignore the
electronUseGetDisplayMediaconfig flag and use the gDM flow. This facilitates having backwards compatibility since the Electron app won't know if the deployment it's about to join has the gDM flow support or not.