fix(rtc) use exact deviceId constraints #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webrtc-adapter transforms "deviceId": "foo" to "deviceId": { ideal:
"foo"}.
This makes the camera non-selectable if the resolution constraints are
not met.
Setting the constraint to exact will sidestep that adapter behavior, and
express stronger intent.
|
Caveat emptor: I'm not 100% certain this won't introduce problems with all browsers, so I suggest a "merge, test in beta, revert if problematic" approach. |
damencho
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webrtc-adapter transforms "deviceId": "foo" to "deviceId": { ideal: "foo"}.
This makes the camera non-selectable if the resolution constraints are not met.
Setting the constraint to exact will sidestep that adapter behavior, and express stronger intent.