feat: Introduces connection event for custom properties. #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for shard and region values coming from the backend.
jallamsetty1
approved these changes
Mar 26, 2024
saghul
approved these changes
Mar 26, 2024
|
|
||
| if (region || shard) { | ||
| // avoids sending empty values | ||
| this.eventEmitter.emit(JitsiConnectionEvents.PROPERTIES_UPDATED, JSON.parse(JSON.stringify({ |
There was a problem hiding this comment.
Suggestion: use lodash clone or structuredClone.
There was a problem hiding this comment.
That will drop the keys with undefined values?
There was a problem hiding this comment.
Yes. That was a quick hack to avoid if this and if that to not add the keys.
damencho
added a commit
that referenced
this pull request
Mar 27, 2024
* feat: Introduces connection event for custom properties. Used for shard and region values coming from the backend. * squash: Update JitsiConnectionEvents.ts * squash: Update JitsiConnectionEvents.ts
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat: Introduces connection event for custom properties. Used for shard and region values coming from the backend. * squash: Update JitsiConnectionEvents.ts * squash: Update JitsiConnectionEvents.ts
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat: Introduces connection event for custom properties. Used for shard and region values coming from the backend. * squash: Update JitsiConnectionEvents.ts * squash: Update JitsiConnectionEvents.ts
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat: Introduces connection event for custom properties. Used for shard and region values coming from the backend. * squash: Update JitsiConnectionEvents.ts * squash: Update JitsiConnectionEvents.ts
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat: Introduces connection event for custom properties. Used for shard and region values coming from the backend. * squash: Update JitsiConnectionEvents.ts * squash: Update JitsiConnectionEvents.ts
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat: Introduces connection event for custom properties. Used for shard and region values coming from the backend. * squash: Update JitsiConnectionEvents.ts * squash: Update JitsiConnectionEvents.ts
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat: Introduces connection event for custom properties. Used for shard and region values coming from the backend. * squash: Update JitsiConnectionEvents.ts * squash: Update JitsiConnectionEvents.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for shard and region values coming from the backend.