Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JitsiTrack): Remove func that's no longer used. #2488

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(JitsiTrack): Remove func that's no longer used. #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions modules/RTC/JitsiLocalTrack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,14 +518,6 @@ export default class JitsiLocalTrack extends JitsiTrack {
*/
_setStream(stream) {
super._setStream(stream);

if (stream) {
// Store the MSID for video mute/unmute purposes.
this.storedMSID = this.getMSID();
logger.debug(`Setting new MSID: ${this.storedMSID} on ${this}`);
} else {
logger.debug(`Setting 'null' stream on ${this}`);
}
}

/**
Expand Down
11 changes: 0 additions & 11 deletions modules/RTC/JitsiTrack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,17 +276,6 @@ export default class JitsiTrack extends EventEmitter {
return this.getStreamId();
}

/**
* Returns the msid of the stream attached to the JitsiTrack object or null
* if no stream is attached.
*/
getMSID() {
const streamId = this.getStreamId();
const trackId = this.getTrackId();

return streamId && trackId ? `${streamId} ${trackId}` : null;
}

/**
* Returns the WebRTC MediaStream instance.
*/
Expand Down
1 change: 0 additions & 1 deletion types/hand-crafted/modules/RTC/JitsiTrack.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export default class JitsiTrack extends EventEmitter {
getId: () => string | null;
isActive: () => boolean;
setAudioLevel: ( audioLevel: number, tpc: TraceablePeerConnection ) => void;
getMSID: () => string | null;
setAudioOutput: ( audioOutputDeviceId: '' | string ) => Promise<unknown>; // TODO: what will this promise contain?
addEventListener: (type: string, listener: (event: any) => void) => void;
}
Loading