Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TPC): Removed unused function #2484

Merged
merged 1 commit into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions modules/RTC/TraceablePeerConnection.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,6 @@ export default function TraceablePeerConnection(
*/
this.localTracks = new Map();

/**
* Keeps tracks of the WebRTC <tt>MediaStream</tt>s that have been added to
* the underlying WebRTC PeerConnection.
* @type {Array}
* @private
*/
this._addedStreams = [];

/**
* @typedef {Object} TPCGroupInfo
* @property {string} semantics the SSRC groups semantics
Expand Down Expand Up @@ -1656,16 +1648,6 @@ TraceablePeerConnection.prototype.setVideoCodecs = function(codecList) {
this.codecSettings.codecList = codecList;
};

/**
* Tells if the given WebRTC <tt>MediaStream</tt> has been added to
* the underlying WebRTC PeerConnection.
* @param {MediaStream} mediaStream
* @returns {boolean}
*/
TraceablePeerConnection.prototype.isMediaStreamInPc = function(mediaStream) {
return this._addedStreams.indexOf(mediaStream) > -1;
};

/**
* Remove local track from this TPC.
* @param {JitsiLocalTrack} localTrack the track to be removed from this TPC.
Expand Down Expand Up @@ -2449,8 +2431,6 @@ TraceablePeerConnection.prototype.close = function() {
}
this.remoteTracks.clear();

this._addedStreams = [];

this._dtmfSender = null;
this._dtmfTonesQueue = [];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ export default class TraceablePeerConnection {
getConfiguredVideoCodec: () => CodecMimeType;
setDesktopSharingFrameRate: (maxFps: number) => void;
setVideoCodecs: ( preferredCodec?: CodecMimeType, disabledCodec?: CodecMimeType ) => void;
isMediaStreamInPc: ( mediaStream: MediaStream ) => boolean;
removeTrack: ( localTrack: JitsiLocalTrack ) => void;
findSenderByKind: ( mediaType: MediaType ) => RTCRtpSender | undefined; // TODO: possible bug in the JSDocs
findReceiverForTrack: ( track: MediaStreamTrack ) => RTCRtpReceiver | undefined;
Expand Down
Loading