feat(JitsiConference): Separate conference name validation errors. #2466
Conversation
…ssed" and "it contains invalid characters like capital letters".
|
Hi, thanks for your contribution! |
JitsiConference.js
Outdated
| @@ -476,7 +481,7 @@ JitsiConference.prototype._init = function(options = {}) { | |||
| userName: config.statisticsDisplayName ? config.statisticsDisplayName : this.myUserId(), | |||
| confID: config.confID || `${this.connection.options.hosts.domain}/${this.options.name}`, | |||
| siteID: config.siteID, | |||
| roomName: this.options.name, | |||
There was a problem hiding this comment.
My bad that should be roomName. Initially I used roomName = options.name, but then I notice that it is mention as conference name in some places and room name on others so renamed all occurrence and this code was corrupted (
|
Since the errors are indistinguishable (no code or other attribute) why is this change useful? |
Rollback invalid rename,
|
So you can close it if it is not important. |
|
Sorry, I don't think this PR improves the current code. Thanks for taking the time to give it a try though! |
Separate thrown errors: "no conference name passed" and "it contains invalid characters like capital letters".