Avoid finally in promise chain. Log error if error happen in _l_lastVideoSenderUpdatePromise.

[Romick2005]

Fixes #2464 _lastVideoSenderUpdatePromise.finally is not a function issue. Add more information about occurred errors.

[jitsi-jenkins]

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

[saghul]

What environment are you running in? Is Promise.prototype.finally not defined there?

[Romick2005]

What environment are you running in? Is Promise.prototype.finally not defined there?

react-native

[saghul]

Then you need to apply the promise finally polyfill.

[Romick2005]

Then you need to apply the promise finally polyfill.

But this pr allow us to see errors also. And this is the only place where we can have more environments covered. Wouldn't it be better? Also this will cover some case with UnhandledPromiseRejection. So for example:

const p = Promise.reject(new Error('BOOM'));
p.finally(() => {});

will throw UnhandledPromiseRejectionWarning
(node:22503) UnhandledPromiseRejectionWarning: Error: BOOM at Object.<anonymous>

But this:

const p = Promise.reject(new Error('BOOM'));
p.catch(() => {}).finally(() => {});

So it is not also about polyfills, but for general code reliability.
nodejs/node#28636
@saghul What do you think?

[saghul]

Error in that function can happen and are ok to ignore, hence the finally.

While what you say is generally good advice, it doesn't need to be followed in every case.

[Romick2005]

Is this a good case to kill two rabbits with one shot? Allow easy react-native integration and have proper error handling and logs?

I do not agree with you. So I will patch it, sorry.