Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watchrtc consecutive call issue #2426

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

subhamcyara
Copy link
Contributor

Following PR contains the following changes :

  1. Update watchRTC SDK version to 1.38.2
  2. remove persistentEnd call to fix web socket connect/disconnect when conducting consecutive calls.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Jan 2, 2024

So is it no longer necessary to make that API call?

@subhamcyara
Copy link
Contributor Author

Yes. We do not require that API call with new changes within our sdk. It helps to curb unnecessarily connect/disconnect (or reconnect) of websocket connections for calls.

saghul
saghul previously approved these changes Jan 2, 2024
@saghul
Copy link
Member

saghul commented Jan 2, 2024

Jenkins please test this please.

@saghul
Copy link
Member

saghul commented Mar 21, 2024

Ops this fell trough the cracks due to the holydays. Can you please give it a rebase?

@subhamcyara subhamcyara force-pushed the fix-watchrtc-consecutive-call-issue branch from 8801d13 to 647e1df Compare March 21, 2024 17:45
@subhamcyara
Copy link
Contributor Author

Hi, I think I did a mistake while merging. I rectified and seems okay now. Please let me know if something seems off.

@saghul
Copy link
Member

saghul commented Mar 21, 2024

Jenkins please test this please.

@saghul saghul merged commit bfbc99b into jitsi:master Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants