Skip to content

Commit

Permalink
fix(video-quality): Bump up the default bitrates for H.264.
Browse files Browse the repository at this point in the history 
The browser is downsampling the resolution since the current default bitrates for H.264 are very conservative.
  • Loading branch information
@jallamsetty1
jallamsetty1 committed May 20, 2024
1 parent 3aa7968 commit 63a0348
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
34 changes: 17 additions & 17 deletions modules/RTC/TPCUtils.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1222,9 +1222,9 @@ describe('TPCUtils', () => {
expect(activeState[2]).toBe(true);

maxBitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(maxBitrates[0]).toBe(200000);
expect(maxBitrates[1]).toBe(500000);
expect(maxBitrates[2]).toBe(1500000);
expect(maxBitrates[0]).toBe(400000);
expect(maxBitrates[1]).toBe(800000);
expect(maxBitrates[2]).toBe(2000000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes[0]).toBe(VideoEncoderScalabilityMode.L1T3);
Expand All @@ -1245,9 +1245,9 @@ describe('TPCUtils', () => {
expect(activeState[2]).toBe(false);

maxBitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(maxBitrates[0]).toBe(200000);
expect(maxBitrates[1]).toBe(500000);
expect(maxBitrates[2]).toBe(1500000);
expect(maxBitrates[0]).toBe(400000);
expect(maxBitrates[1]).toBe(800000);
expect(maxBitrates[2]).toBe(2000000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes[0]).toBe(VideoEncoderScalabilityMode.L1T3);
Expand All @@ -1268,9 +1268,9 @@ describe('TPCUtils', () => {
expect(activeState[2]).toBe(false);

maxBitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(maxBitrates[0]).toBe(200000);
expect(maxBitrates[1]).toBe(500000);
expect(maxBitrates[2]).toBe(1500000);
expect(maxBitrates[0]).toBe(400000);
expect(maxBitrates[1]).toBe(800000);
expect(maxBitrates[2]).toBe(2000000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes[0]).toBe(VideoEncoderScalabilityMode.L1T3);
Expand Down Expand Up @@ -1366,8 +1366,8 @@ describe('TPCUtils', () => {
expect(activeState[2]).toBe(true);

maxBitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(maxBitrates[0]).toBe(200000);
expect(maxBitrates[1]).toBe(500000);
expect(maxBitrates[0]).toBe(400000);
expect(maxBitrates[1]).toBe(800000);
expect(maxBitrates[2]).toBe(2500000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
Expand Down Expand Up @@ -1412,7 +1412,7 @@ describe('TPCUtils', () => {
expect(activeState[0]).toBe(true);

maxBitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(maxBitrates[0]).toBe(1500000);
expect(maxBitrates[0]).toBe(2000000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes).toBe(undefined);
Expand All @@ -1427,7 +1427,7 @@ describe('TPCUtils', () => {
expect(activeState[0]).toBe(true);

maxBitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(maxBitrates[0]).toBe(500000);
expect(maxBitrates[0]).toBe(800000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes).toBe(undefined);
Expand All @@ -1442,7 +1442,7 @@ describe('TPCUtils', () => {
expect(activeState[0]).toBe(true);

maxBitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(maxBitrates[0]).toBe(200000);
expect(maxBitrates[0]).toBe(400000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes).toBe(undefined);
Expand Down Expand Up @@ -2533,7 +2533,7 @@ describe('TPCUtils', () => {
expect(activeState[0]).toBe(true);

bitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(bitrates[0]).toBe(1500000);
expect(bitrates[0]).toBe(2000000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes).toBe(undefined);
Expand All @@ -2549,7 +2549,7 @@ describe('TPCUtils', () => {
expect(activeState[0]).toBe(true);

bitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(bitrates[0]).toBe(500000);
expect(bitrates[0]).toBe(800000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes).toBe(undefined);
Expand All @@ -2565,7 +2565,7 @@ describe('TPCUtils', () => {
expect(activeState[0]).toBe(true);

bitrates = tpcUtils.calculateEncodingsBitrates(track, codec, height);
expect(bitrates[0]).toBe(200000);
expect(bitrates[0]).toBe(400000);

scalabilityModes = tpcUtils.calculateEncodingsScalabilityMode(track, codec, height);
expect(scalabilityModes).toBe(undefined);
Expand Down
10 changes: 5 additions & 5 deletions service/RTC/StandardVideoSettings.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ export const STANDARD_CODEC_SETTINGS = {
},
h264: {
maxBitratesVideo: {
low: 200000,
standard: 500000,
high: 1500000,
fullHd: 3000000,
ultraHd: 6000000,
low: 400000,
standard: 800000,
high: 2000000,
fullHd: 4000000,
ultraHd: 8000000,
ssHigh: 2500000,
none: 0
},
Expand Down

0 comments on commit 63a0348

Please sign in to comment.