ref(TPC) Pass bare objects to methods that take SDP instead of passin…

…g an instance of RTCSessionDescription. The constructor for RTCSessionDescription has been deprecated - https://developer.mozilla.org/en-US/docs/Web/API/RTCSessionDescription/RTCSessionDescription.
jitsi · Nov 25, 2024 · 60e680e · 60e680e
1 parent 76c66eb
commit 60e680e
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 26 deletions.
diff --git a/modules/RTC/TPCUtils.js b/modules/RTC/TPCUtils.js
@@ -470,10 +470,10 @@ export class TPCUtils {
             mLine.ssrcs = reorderedSsrcs;
         });
 
-        return new RTCSessionDescription({
+        return {
             type: description.type,
             sdp: transform.write(parsedSdp)
-        });
+        };
     }
 
     /**
@@ -626,10 +626,10 @@ export class TPCUtils {
             }
         });
 
-        return new RTCSessionDescription({
+        return {
             type: desc.type,
             sdp: transform.write(sdp)
-        });
+        };
     }
 
     /**
@@ -703,10 +703,10 @@ export class TPCUtils {
             }
         }
 
-        return new RTCSessionDescription({
+        return {
             type: description.type,
             sdp: transform.write(parsedSdp)
-        });
+        };
     }
 
     /**
@@ -776,10 +776,10 @@ export class TPCUtils {
             fmtpOpus.config = mungedConfig.trim();
         }
 
-        return new RTCSessionDescription({
+        return {
             type: description.type,
             sdp: transform.write(parsedSdp)
-        });
+        };
     }
 
     /**
@@ -842,10 +842,10 @@ export class TPCUtils {
             }
         }
 
-        return new RTCSessionDescription({
+        return {
             type: description.type,
             sdp: transform.write(parsedSdp)
-        });
+        };
     }
 
     /**
@@ -892,9 +892,9 @@ export class TPCUtils {
             }
         });
 
-        return new RTCSessionDescription({
+        return {
             type: description.type,
             sdp: transform.write(parsedSdp)
-        });
+        };
     }
 }
diff --git a/modules/RTC/TraceablePeerConnection.js b/modules/RTC/TraceablePeerConnection.js
@@ -1233,10 +1233,10 @@ TraceablePeerConnection.prototype._injectSsrcGroupForUnifiedSimulcast = function
         }
     }
 
-    return new RTCSessionDescription({
+    return {
         type: desc.type,
         sdp: transform.write(sdp)
-    });
+    };
 };
 
 /* eslint-disable-next-line vars-on-top */
@@ -1797,10 +1797,10 @@ TraceablePeerConnection.prototype._adjustRemoteMediaDirection = function(remoteD
         });
     });
 
-    return new RTCSessionDescription({
+    return {
         type: remoteDescription.type,
         sdp: transformer.toRawSDP()
-    });
+    };
 };
 
 /**
@@ -2458,10 +2458,10 @@ TraceablePeerConnection.prototype._createOfferOrAnswer = function(isOffer, const
 
             if (!this.options.disableRtx && browser.usesSdpMungingForSimulcast()) {
                 // eslint-disable-next-line no-param-reassign
-                resultSdp = new RTCSessionDescription({
+                resultSdp = {
                     type: resultSdp.type,
                     sdp: this.rtxModifier.modifyRtxSsrcs(resultSdp.sdp)
-                });
+                };
 
                 this.trace(
                     `create${logName}`

diff --git a/modules/sdp/LocalSdpMunger.js b/modules/sdp/LocalSdpMunger.js
@@ -144,9 +144,9 @@ export default class LocalSdpMunger {
             this._transformMediaIdentifiers(videoMLine, ssrcMap);
         }
 
-        return new RTCSessionDescription({
+        return {
             type: sessionDesc.type,
             sdp: transformer.toRawSDP()
-        });
+        };
     }
 }
diff --git a/modules/sdp/SdpSimulcast.ts b/modules/sdp/SdpSimulcast.ts
@@ -227,9 +227,9 @@ export default class SdpSimulcast {
             }
         }
 
-        return new RTCSessionDescription({
+        return {
             type: description.type,
             sdp: transform.write(session)
-        });
+        };
     }
 }
diff --git a/modules/xmpp/JingleSessionPC.js b/modules/xmpp/JingleSessionPC.js
@@ -655,10 +655,10 @@ export default class JingleSessionPC extends JingleSession {
             return Promise.reject(error);
         }
 
-        const remoteDescription = new RTCSessionDescription({
+        const remoteDescription = {
             type: 'offer',
             sdp: remoteSdp
-        });
+        };
 
         const oldLocalSDP = this.peerconnection.localDescription.sdp;
 
@@ -2062,10 +2062,10 @@ export default class JingleSessionPC extends JingleSession {
 
         const newRemoteSdp = this._processNewJingleOfferIq(jingleAnswer);
         const oldLocalSdp = new SDP(this.peerconnection.localDescription.sdp);
-        const remoteDescription = new RTCSessionDescription({
+        const remoteDescription = {
             type: 'answer',
             sdp: newRemoteSdp.raw
-        });
+        };
 
         this.peerconnection.setRemoteDescription(remoteDescription)
             .then(() => {