Skip to content

refactor(mobile): Move querySelector polyfill to @jitsi/js-utils package #16567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

refactor(mobile): Move querySelector polyfill to @jitsi/js-utils package #16567

merged 1 commit into from
Oct 22, 2025

Conversation

@hristoterezov
Copy link
Member

@hristoterezov hristoterezov commented Oct 18, 2025 •
edited
Loading

Summary

  • Moves querySelector/querySelectorAll polyfill implementation from local codebase to @jitsi/js-utils package (v2.6.1)
  • Removes 282 lines of local polyfill code
  • Updates mobile browser.js to import from @jitsi/js-utils instead of local file
  • Simplifies polyfill calls by removing unnecessary documentElement checks (now handled in the package)

Benefits

  • Reduces code duplication: The polyfill is now maintained in a shared package
  • Enables reuse: Other projects using @jitsi/js-utils can benefit from this polyfill
  • Centralizes maintenance: Bug fixes and improvements only need to be made in one place
  • Ensures consistency: The same polyfill implementation is used across the Jitsi ecosystem

Test plan

  • Test React Native mobile app with XML parsing (lib-jitsi-meet -> XMLUtils.ts -> parseXML)
  • Verify querySelector and querySelectorAll work correctly on mobile
  • Test with strophe.js XML processing
  • Ensure no regressions in mobile polyfill functionality

saghul
saghul approved these changes Oct 18, 2025
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring the failing tests.

@hristoterezov
refactor(mobile): Move querySelector polyfill to @jitsi/js-utils package
f75bcda 
Moves the querySelector/querySelectorAll polyfill implementation from the local codebase to the @jitsi/js-utils package (v2.6.1) to reduce code duplication and make the polyfill available to other projects. This centralizes maintenance and ensures consistent behavior across the Jitsi ecosystem.
@hristoterezov hristoterezov force-pushed the move-query-selector-polyfill branch from 43baae1 to f75bcda Compare October 22, 2025 19:03
@hristoterezov hristoterezov merged commit fff6636 into master Oct 22, 2025
10 checks passed
@hristoterezov hristoterezov deleted the move-query-selector-polyfill branch October 22, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saghul saghul saghul approved these changes

@damencho damencho damencho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hristoterezov @saghul @damencho