Skip to content

Commit

Permalink
fix(config): Enable ssrc-rewriting by default. (#14567)
Browse files Browse the repository at this point in the history
  • Loading branch information
jallamsetty1 authored Mar 29, 2024
1 parent 5247fbd commit d1590db
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 8 deletions.
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"js-md5": "0.6.1",
"js-sha512": "0.8.0",
"jwt-decode": "2.2.0",
"lib-jitsi-meet": "https://github.com/jitsi/lib-jitsi-meet/releases/download/v1803.0.0+5237dbfe/lib-jitsi-meet.tgz",
"lib-jitsi-meet": "https://github.com/jitsi/lib-jitsi-meet/releases/download/v1806.0.0+b0356800/lib-jitsi-meet.tgz",
"lodash": "4.17.21",
"moment": "2.29.4",
"moment-duration-format": "2.2.2",
Expand Down
2 changes: 1 addition & 1 deletion react/features/base/config/functions.any.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function getMeetingRegion(state: IReduxState) {
* @returns {boolean}
*/
export function getSsrcRewritingFeatureFlag(state: IReduxState) {
return getFeatureFlag(state, FEATURE_FLAGS.SSRC_REWRITING);
return getFeatureFlag(state, FEATURE_FLAGS.SSRC_REWRITING) ?? true;
}

/**
Expand Down
12 changes: 11 additions & 1 deletion react/features/base/connection/actions.any.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export function constructOptions(state: IReduxState) {
options.iceServersOverride = iceServersOverride;
}

const { bosh, preferBosh } = options;
const { bosh, preferBosh, flags } = options;
let { websocket } = options;

// TESTING: Only enable WebSocket for some percentage of users.
Expand Down Expand Up @@ -162,6 +162,16 @@ export function constructOptions(state: IReduxState) {
options.preferVisitor = true;
}

// Enable ssrc-rewriting by default.
if (typeof flags?.ssrcRewritingEnabled === 'undefined') {
const { ...otherFlags } = flags ?? {};

options.flags = {
...otherFlags,
ssrcRewritingEnabled: true
};
}

return options;
}

Expand Down

0 comments on commit d1590db

Please sign in to comment.