Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native getDisplayMedia #1000

Merged
merged 8 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
build-linux:
name: Linux
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand Down
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Desktop application for [Jitsi Meet] built with [Electron].
- [End-to-End Encryption](https://jitsi.org/blog/e2ee/) support (BETA)
- Works with any Jitsi Meet deployment
- Built-in auto-updates
- Screensharing (Windows, Mac, Linux on X11 only. Not supported under Wayland, see known issues below)
- Screen sharing
- ~Remote control~ (currently [disabled](https://github.com/jitsi/jitsi-meet-electron/issues/483) due to [security issues](https://github.com/jitsi/security-advisories/blob/master/advisories/JSA-2020-0001.md))
- Always-On-Top window
- Support for deeplinks such as `jitsi-meet://myroom` (will open `myroom` on the configured Jitsi instance) or `jitsi-meet://jitsi.mycompany.com/myroom` (will open `myroom` on the Jitsi instance running on `jitsi.mycompany.com`)
Expand Down Expand Up @@ -144,10 +144,6 @@ None

* If you can't execute the file directly after downloading it, try running `chmod u+x ./jitsi-meet-x86_64.AppImage`

* Under Wayland, screensharing is currently buggy:
* Sharing a full screen is not possible
* When trying to start screensharing under Wayland, 2 permission popups will show up. First a PipeWire-based system selector, then a Jitsi internal selector. Select the application window in the first selector and click allow; then do the same in the Jitsi internal selector. This is how sharing application windows works, as sharing a full screen is unfortunately not possible.

* On Ubuntu 22.04 and later, the AppImage will fail with a FUSE error (as the AppImage uses `libfuse2`, while 22.04 comes with `libfuse3` by default):

```
Expand Down
6 changes: 1 addition & 5 deletions app/features/conference/components/Conference.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,14 +210,10 @@ class Conference extends Component<Props, State> {
...locale
};

// override both old and new prejoin config options,
// old one for servers that do not understand the new option yet
// and new one for newly setup servers where the new option overrides
// the old if set.

const configOverwrite = {
enableCalendarIntegration: false,
disableAGC: this.props._disableAGC,
prejoinPageEnabled: true,
prejoinConfig: {
enabled: true
}
Expand Down
2 changes: 1 addition & 1 deletion app/features/conference/external_api.js

Large diffs are not rendered by default.

Loading