Skip to content

Commit

Permalink
chore(deps): remove process polyfill (#738)
Browse files Browse the repository at this point in the history
The @atlaskit/navigation also works fine without reference
to whether its running on mac or not (for the way its used in
this project).
  • Loading branch information
csett86 authored Mar 25, 2022
1 parent f58f8c9 commit 5c53a8c
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 38 deletions.
2 changes: 0 additions & 2 deletions app/features/navbar/components/Navbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import React, { Component } from 'react';
import { connect } from 'react-redux';

import { SettingsButton, SettingsDrawer } from '../../settings';
import { isElectronMac } from '../../utils';

import HelpButton from './HelpButton';
import Logo from './Logo';
Expand Down Expand Up @@ -66,7 +65,6 @@ class Navbar extends Component<Props, *> {
globalPrimaryActions = { this._getPrimaryActions() }
globalPrimaryIcon = { <Logo /> }
globalSecondaryActions = { this._getSecondaryActions() }
isElectronMac = { isElectronMac() }
isOpen = { false }
isResizeable = { false } />
);
Expand Down
11 changes: 0 additions & 11 deletions app/features/utils/functions.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
/* global process */

// @flow


/**
* Return true if Electron app is running on Mac system.
*
* @returns {boolean}
*/
export function isElectronMac() {
return process.platform === 'darwin';
}

/**
* Normalizes the given server URL so it has the proper scheme.
*
Expand Down
16 changes: 0 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@
"moment": "^2.29.1",
"mousetrap": "^1.6.5",
"patch-package": "6.2.2",
"process": "^0.11.10",
"react": "^16.14.0",
"react-dom": "^16.14.0",
"react-i18next": "^11.8.12",
Expand Down
9 changes: 1 addition & 8 deletions webpack.renderer.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const webpack = require('webpack');
const ELECTRON_VERSION = require('./package.json').devDependencies.electron;

module.exports = {
Expand All @@ -15,9 +14,6 @@ module.exports = {
plugins: [
new HtmlWebpackPlugin({
template: './app/index.html'
}),
new webpack.ProvidePlugin({
process: 'process/browser'
})
],
output: {
Expand Down Expand Up @@ -84,10 +80,7 @@ module.exports = {
resolve: {
modules: [
path.resolve('./node_modules')
],
alias: {
process: 'process/browser'
}
]
}
};

0 comments on commit 5c53a8c

Please sign in to comment.