Making things more flexible

[jasonwbarnett]

Just thought I would submit my changes back to you, just in case any one still uses this :)

Overview of changes:

• Move API query details into Bart::Utils
• Move the parsing of API responses into Bart::Utils
• Removed static list of stations (stations.rb) and replaced it with a dynamic API call.
• Allow changing the Bart::Station abbr without initializing another Bart::Station object.
• Allow setting the API Key when creating initializing Bart::Station

[jish]

Hey thanks for the submission. Is this the whole of another fork you are maintaining?

A few thoughts:

• It looks like there are some breaking API changes, so to incorporate we'd have to do a major version bump (which should be totally fine)
• It looks like we're mixing spec style tests with test/unit style tests. We should probably settle on one for consistency's sake
• There is a lot here. We might have to split this up into chunks. For instance, switching the master branch to use Ruby 1.9+ syntax would probably cut down on the diff of the actual changes a bit.

[jasonwbarnett]

Yes, it's the whole of another fork I am maintaining. I created the fork like a week or two ago for a rails project I'm working on.

• Sounds good.
• I honestly have never done testing before in my entire life, hence the disaster :)
• Yeah there is definitely a lot here. I think that 1.9+ syntax sounds like a great start. I my code and break it into smaller chunks if need be. Have any ideas for that?

[jish]

break it into smaller chunks if need be. Have any ideas for that?

Sure, we can create an issue for each item and go one by one. First up Ruby 1.9 syntax #2