Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

Fallback if there are insufficient primaries or if there is an error#31

Closed
mikehardy wants to merge 3 commits intojimmygchen:mainfrom
mikehardy:extra-merges
Closed

Fallback if there are insufficient primaries or if there is an error#31
mikehardy wants to merge 3 commits intojimmygchen:mainfrom
mikehardy:extra-merges

Conversation

@mikehardy
Copy link
Copy Markdown

@mikehardy mikehardy commented Oct 17, 2025

Implements the request I made:

Is based on the orgs and repos API addition which I also needed (thanks @O-Mutt!):

In a follow-on commit, I added the 'fallback-on-error' optional boolean, default false (for backwards-compatibility in behavior). If true, the action will automatically return the fallback runner (if configured!) in case of any errors. That way CI won't just stop working if your token expires, or the token was unavailable (as happened to me since dependabot secrets are separate and the action had no access to the token). It prints an explicit warning about what the problem was and why it is continuing anyway if you use this new feature

@mikehardy mikehardy force-pushed the extra-merges branch 3 times, most recently from 0948bd7 to f00f534 Compare October 18, 2025 00:42
@mikehardy mikehardy changed the title Fallback if all primaries are busy Fallback if there are insufficient primaries Oct 18, 2025
this allows you to use the primaries to augment capacity vs replace capacity
can help make your CI future-failure-proof in case tokens expire
or are unexpectedly unavailable, at least CI will continue functioning
with fallback
@mikehardy mikehardy changed the title Fallback if there are insufficient primaries Fallback if there are insufficient primaries or if there is an error Oct 27, 2025
@jimmygchen
Copy link
Copy Markdown
Owner

Hi @mikehardy

Really appreciate you taking the time to put this together! I’m no longer maintaining this project and will probably archive it soon.

So I won’t be reviewing or merging new PRs, but feel free to keep your fork going if you’d like to continue development though. Thanks again for contributing! 🙏

@mikehardy
Copy link
Copy Markdown
Author

Hey @jimmygchen totally fair, I just disavowed maintenance on another library, you should only spend time on the things that make sense. I think it's a great action though and I'm really grateful you started it.

I'll consider my fork to be the "authoritative" fork for my own uses then and formalize it's release a bit.

@O-Mutt - if you want to use the extra-merges branch on my fork we can collaborate over there - I'm using it in production with the AnkiDroid project (~3 million users on Play Store, not saying we're amazing or anything just saying that we're doing real work and try to make and use software that works for real, with lots and lots of CI activity)

Cheers!

@O-Mutt
Copy link
Copy Markdown

O-Mutt commented Oct 28, 2025

👍 thank you for the update @jimmygchen and thank you for the base project! Such a beautiful idea. I think it would be good to archive if you no longer plan to maintain ❤️

@mikehardy I will likely move over to your branch as the authoritative fork 👍

@mikehardy
Copy link
Copy Markdown
Author

@O-Mutt sounds good - as final note then, the extra-merges branch is the source for this PR so you know what's in there. Intention was for my extra features that fallback with insufficient primaries or fallback on error are both optional + should be backwards compatible. And are based on your PR :-). So you should be able to move directly, if not, open an issue over on my fork and I'll check it. Cheers all

@O-Mutt
Copy link
Copy Markdown

O-Mutt commented Oct 28, 2025

You got'er boss! Thanks!

@mikehardy
Copy link
Copy Markdown
Author

going to close this since it won't be merged - v1 tag (for stable usage in yml) is up on my fork now

@mikehardy mikehardy closed this Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants