Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Commit

Permalink
Merge pull request #1 from jiakai-li/feature/replace-emoji-face
Browse files Browse the repository at this point in the history
Replace the emoji in an error message
  • Loading branch information
jiakai-li authored Sep 9, 2024
2 parents 7b82b8c + 9d2833b commit 2d65b90
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
uses: actions/checkout@v3
- name: Run end-to-end tests
run: >
docker-compose --profile testing up
docker compose --profile testing up
--build
--exit-code-from test
- name: Login to Docker Hub
Expand Down
2 changes: 1 addition & 1 deletion web/src/page_tracker/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def index():
page_views = redis().incr("page_views")
except RedisError:
app.logger.exception("Redis error")
return "Sorry, something went wrong \N{pensive face}", 500
return "Sorry, something went wrong \N{thinking face}", 500
else:
return f"This page has been viewed {page_views} times"

Expand Down
2 changes: 1 addition & 1 deletion web/test/unit/test_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ def test_should_handle_redis_connection_error(mock_redis, http_client):
mock_redis.return_value.incr.side_effect = ConnectionError
response = http_client.get("/")
assert response.status_code == 500
assert response.text == "Sorry, something went wrong \N{pensive face}"
assert response.text == "Sorry, something went wrong \N{thinking face}"

0 comments on commit 2d65b90

Please sign in to comment.