Fix #87 support d3 v4, and add horizontal zoom (fixes #57)#93
Fix #87 support d3 v4, and add horizontal zoom (fixes #57)#93fidlr wants to merge 5 commits intojiahuang:masterfrom
Conversation
Added horizontal zooming with mouse wheel (closes jiahuang#57). Code cleanup. Fixed newely introduced bugs: (1) background occluding data rects, (2) support for xaxis orientation top. Added grouping of the data rects in the svg (viewport).
fidlr
changed the title
|
You have saved my week fidlr! This is fantastic. Thank you. |
|
Happy to help @kwe7 |
…cific rects from the outside
|
Hi fidlr, do you know how to apply clipping to your zoom feature? The zoom works perfectly, but the timeline will expand to block my view of the y-axis values. Also, I think this might be more of a me problem, but upon following your v4 updates, my time axis shows correct minutes but not correct hours. d.starting_time and d.ending_time are still correct. Do you have any insight as to why only my time axis was affected in this way? Thanks! |
|
I have the same issue with the labels, but it was like that in the original code with scrolling so I left it as-is for now. I might get back to it later if it becomes an issue. If you post a fix, I'd definitely want it. |
|
I think that I have successfully added clipping for the zoom. How do I add a commit so everyone can see the changes? |
|
You can either fork and submit a pull request, or attach a patch, and I'd be happy to merge it to this fork. |
2 participants
No description provided.