Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $duration to initial-variables #3946

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add $duration to initial-variables #3946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Fix #3842: restore use of `$easing`, `$radius-rounded` and `$speed` Sass variables
- Fix #3920: migrate code to avoid Sass 1.80 deprecation warning of global built-in functions
- Fix #3945: add `$duration` Sass variable

### Documentation Fixes

Expand Down Expand Up @@ -34,7 +35,7 @@
- `--bulma-input-border-width`
- `--bulma-label-color`
- `--bulma-label-spacing`
- `--bulma-label-weight`
- `--bulma-label-weight`
- `--bulma-help-size`
- `--bulma-field-block-spacing`

Expand Down Expand Up @@ -71,7 +72,7 @@
- Fix #3785: make use of the `@prefers-reduced-motion` setting
- Fix #3758: broken links for `0.9.4` version
- Fix #3760: fix form controls typo

### Improvements

- Fix #3737: Move `sass` to `devDependencies`
Expand Down Expand Up @@ -161,7 +162,7 @@ The Sass placeholders are:
- `%loader`
- `%overlay`

If you were importing them directly from `utilities/mixins`, you'll need to import `utilities/extends` instead.
If you were importing them directly from `utilities/mixins`, you'll need to import `utilities/extends` instead.
If you were importing `utilities/_all` or even `bulma.sass` directly, no change is required.

### New features
Expand Down
4 changes: 4 additions & 0 deletions docs/_data/variables/utilities/initial-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@
"name": "breakpoints",
"value": "(\n \"mobile\": (\n \"until\": $tablet,\n ),\n \"tablet\": (\n \"from\": $tablet,\n ),\n \"tablet-only\": (\n \"from\": $tablet,\n \"until\": $desktop,\n ),\n \"touch\": (\n \"from\": $desktop,\n ),\n \"desktop\": (\n \"from\": $desktop,\n ),\n \"desktop-only\": (\n \"from\": $desktop,\n \"until\": $widescreen,\n ),\n \"until-widescreen\": (\n \"until\": $widescreen,\n ),\n \"widescreen\": (\n \"from\": $widescreen,\n ),\n \"widescreen-only\": (\n \"from\": $widescreen,\n \"until\": $fullhd,\n ),\n \"until-fullhd\": (\n \"until\": $fullhd,\n ),\n \"fullhd\": (\n \"from\": $fullhd,\n ),\n)"
},
{
"name": "duration",
"value": "294ms"
},
{
"name": "easing",
"value": "ease-out"
Expand Down
2 changes: 1 addition & 1 deletion sass/themes/light.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ $scheme-main: hsl(iv.$scheme-h, iv.$scheme-s, $scheme-main-l);

// Other
"block-spacing": iv.$block-spacing,
"duration": 294ms,
"duration": iv.$duration,
"easing": iv.$easing,
"radius-small": iv.$radius-small,
"radius": iv.$radius,
Expand Down
1 change: 1 addition & 0 deletions sass/utilities/initial-variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ $breakpoints: (

// Miscellaneous

$duration: 294ms !default;
$easing: ease-out !default;
$radius-small: 0.25rem !default;
$radius: 0.375rem !default;
Expand Down