Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC1101 Variable Preamble Length #71

Merged
merged 3 commits into from
Nov 18, 2019
Merged

CC1101 Variable Preamble Length #71

merged 3 commits into from
Nov 18, 2019

Conversation

aguglie
Copy link
Contributor

@aguglie aguglie commented Nov 18, 2019

No description provided.

@jgromes
Copy link
Owner

jgromes commented Nov 18, 2019

Thanks for the contribution, few remarks:

  1. Could you add preambleLength parameter to the CC1101::begin() method, set to 4 by default? Other FSK radio modules have this parameter.
  2. The doxygen comment should mention in the /param section what is the unit of preamble length - bytes, bits, something else?

Other than that, everything looks fine.

@jgromes jgromes merged commit 37d8b60 into jgromes:master Nov 18, 2019
@jgromes
Copy link
Owner

jgromes commented Nov 18, 2019

The Travis error is due to ESP8266 breaking SoftwareSerial again, so I think we can merge this, thanks!

@aguglie
Copy link
Contributor Author

aguglie commented Nov 18, 2019

Yep! I had the same problem but tought I had an obsolete esp8266 framework :)
Seems like you already fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aguglie @jgromes