Revisioned promiscious-mode implementation for CC1101 and RF69 #63 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/jgromes/RadioLib: Fixed keyword separator Fixed SoftwareSerial for ESP8266 core 2.6.0 [SX126x] Moved debug output out of SPI transaction
* 'master' of https://github.com/jgromes/RadioLib: Comment and error checking cleanup. Fixed power adjustment for SX1261 Removed memory allocation and copying from SX126X read* and write* functions Implemented optimal PA settings for SX1268. Ensured OCP is always restored when changing power. Slight refactor to avoid duplicated SX1262 / SX1268 code. Fixed link to ESP32 package index Implemented power scaling in setOutputPower, in accordance with datasheet. Missed SX1261 PA Config flag in previous commit Adjusted setPaConfig in SX126x setOutputPower.
|
Merged, release most likely later this week. Thank you very much for this contribution, I really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promiscuous mode is needed in sniffing scenarios, similarly to variable vs. fixed packet mode. I also made
setSyncWorduniform, retaining the original signature for compatibility.I'm not aware of a way to disable sync word detection alone in CC1101. The only way I know also disables preamble detection altogether. Therefore,
disableSyncWordFilteringalso disables preamble filtering.If you know a better way to address this, I'll commit some changes.