Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed memory allocation and copying from SX126X #64

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

BarryPSmith
Copy link
Contributor

Extends command interface to allow multi-byte commands.

This allows functions that need to prepend some parameters onto input data to do so without allocating memory and performing a memcpy.

Benefits:

  • SX126x code can now be used without linking in operator new
  • Allows transmit and receive to be called when not much memory is available: previously these functions could allocate as much as 257 bytes when dealing with large messages.
  • Improved performance by removing memcpy

@jgromes
Copy link
Owner

jgromes commented Nov 13, 2019

Looks good, was this tested on hardware?

@BarryPSmith
Copy link
Contributor Author

Yes, this is tested.

Aside: I noticed that my pull requests might conflict with each other. If this happens let me know and I can rebase the remaining ones and resolve the conflicts..

@jgromes jgromes merged commit 1ea77c9 into jgromes:master Nov 13, 2019
@jgromes
Copy link
Owner

jgromes commented Nov 13, 2019

Merged, thanks.

There's no conflict in this one, though there's a minor one in #61

@BarryPSmith BarryPSmith deleted the sx126x_noMemAllocations branch November 13, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants