Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented promiscious mode for CC1101 and RF69 #63

Closed
wants to merge 7 commits into from

Conversation

phretor
Copy link
Contributor

@phretor phretor commented Nov 12, 2019

Promiscuous mode is needed in sniffing scenarios, similarly to variable vs. fixed packet mode. I also made setSyncWord uniform, retaining the original signature for compatibility.

I'm not aware of a way to disable sync word detection alone in CC1101. The only way I know also disables preamble detection altogether. Therefore, disableSyncWordFiltering also disables preamble filtering.

If you know a better way to address this, I'll commit some changes.

* 'master' of https://github.com/jgromes/RadioLib:
  Fixed keyword separator
  Fixed SoftwareSerial for ESP8266 core 2.6.0
  [SX126x] Moved debug output out of SPI transaction
Copy link
Owner

@jgromes jgromes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess promiscuous mode is pretty much required for your use-case ;)

Please also add the new methods to keywords.txt (with TAB separator).

src/modules/CC1101.cpp Show resolved Hide resolved
src/modules/CC1101.cpp Show resolved Hide resolved
src/modules/CC1101.cpp Show resolved Hide resolved
src/modules/CC1101.cpp Show resolved Hide resolved
src/modules/CC1101.cpp Outdated Show resolved Hide resolved
src/modules/RF69.cpp Show resolved Hide resolved
src/modules/RF69.cpp Outdated Show resolved Hide resolved
src/modules/RF69.cpp Outdated Show resolved Hide resolved
src/modules/RF69.h Outdated Show resolved Hide resolved
@jgromes
Copy link
Owner

jgromes commented Nov 12, 2019

I'm not aware of a way to disable sync word detection alone in CC1101

Neither am I, sorry. Then again, I don't use that radio much - it was added on request.

Also, please ignore the Travis errors - it's because ESP32 builds fail since Espressif's website returns timeouts at the moment.

* 'master' of https://github.com/jgromes/RadioLib:
  Comment and error checking cleanup. Fixed power adjustment for SX1261
  Removed memory allocation and copying from SX126X read* and write* functions
  Implemented optimal PA settings for SX1268. Ensured OCP is always restored when changing power. Slight refactor to avoid duplicated SX1262 / SX1268 code.
  Fixed link to ESP32 package index
  Implemented power scaling in setOutputPower, in accordance with datasheet.
  Missed SX1261 PA Config flag in previous commit
  Adjusted setPaConfig in SX126x setOutputPower.
@phretor phretor closed this Nov 13, 2019
@phretor
Copy link
Contributor Author

phretor commented Nov 13, 2019

Sorry, not ready yet.

jgromes added a commit that referenced this pull request Nov 13, 2019
Revisioned promiscious-mode implementation for CC1101 and RF69 #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants