Using defined debug port and not Serial + CC1101 length mode config options #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phretor
changed the title
|
Proposal on how to address #54 in the CC1101 module. I can implement and send more pull request for other modules if this approach is acceptable. |
jgromes
requested changes
Nov 6, 2019
There was a problem hiding this comment.
Please also address the following:
- Add call to
CC1101::variablePacketLengthMode()inCC1101::begin()to set the default configuration on startup. - In
CC1101::packetMode(), use the private variableCC1101::_packetLengthConfigto set the packet mode (currently it would always set it to variable) - Add new public methods to keywords.txt (use true tab as separator, not spaces)
|
Thanks for the thorough review. I'll handle the comments. Should I just make a new pull request or merge new changes with this one? |
|
New PR for the new changes in other radio modules seems more appropriate, thanks. |
Updating _packetLengthConfig and _packetLength properly
|
Changeset 112110d should address your requests. |
jgromes
requested changes
Nov 7, 2019
There was a problem hiding this comment.
Almost there ;)
Also, please address the following:
- Add call to CC1101::variablePacketLengthMode() in CC1101::begin() to set the default configuration on startup.
- In CC1101::packetMode(), use the private variable CC1101::_packetLengthConfig to set the current packet mode (currently, it would always set it to variable, even if the user set to fixed prior to calling packetMode())
- Add new public methods to keywords.txt (use true tab as separator, not spaces)
…Mode before CC1101::config so as to maintain the same order as in the header file
|
Commit a2e64f1 should do it. |
jgromes
approved these changes
Nov 8, 2019
|
Looks good to me - merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.