ESP32 - use HardwareSerial instead of SoftwareSerial #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP32 has no working SoftwareSerial. With a simple #ifdef ESP32 a hardware serial will be used instead. Minimum changes without influence on existing installations or usage.
|
I know you are not targeting the ESP32. But your library is the best LoRa library I found. Would be a pitty if the ESP32 would be left out. |
|
The same thing is valid for SAMD platform (Arduino Zero), so +1 for this PR and use it like #if defined(ESP32) || defined(SAMD_SERIES) ... |
ESP32 has no working SoftwareSerial. With a simple #ifdef ESP32 a hardware serial will be used instead. Minimum changes without influence on existing installations or usage.
This reverts commit ec686e4.
|
@Pablo2048 Anyway, I somehow messed up this pull request, will retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32 has no working SoftwareSerial. With a simple #ifdef ESP32 a hardware serial will be used instead.
Minimum changes without influence on existing installations or usage.