[LR11X0] Add support for specifying PA ramp time #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Lots if whitespace changes here - any chance you can leave those out? :) |
Owner
|
@Dazza0 Thank you - everything looks good in terms of the PA ramp time, however, please leave out the whitespace changes so that we can deal with those in the separate PR. |
- `setOutputPower()` now accepts a `rampTimeUs` argument - `roundRampTime()` rounds up the ramp time to a discerte register value supported by the LR11X0 module.
Dazza0
force-pushed
the
feature/add_ramp_time
branch
from
23f49f3 to
70b0a89
Compare
Contributor
Author
|
@jgromes Whitespace changes removed |
Owner
|
@Dazza0 looking good now - merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for specifying PA power ramp time on the LR11X0 targets by adding an extra
rampTimeUsparameter to thesetOutputPower()function.Note: The LR11x0 targets only support discrete ramp times. A
roundRampTime()helper function is added to round up a ramp time to the nearest supported ramp time. Conversion is done viaif/else ifdue to the discrete ramp times not scale linearly.