Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old warning message for OAuth and SAML resources #1020

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Remove old warning message for OAuth and SAML resources #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec233a9
Remove old warning message for OAuth and SAML resources
alexhung Jul 10, 2024
79605e4
Update CHANGELOG
alexhung Jul 10, 2024
801ca56
Update CHANGELOG
alexhung Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@ IMPROVEMENTS:
* `artifactory_release_bundle_v2_promotion_custom_webhook`
* `artifactory_artifact_lifecycle_custom_webhook`

Issue: [#1012](https://github.com/jfrog/terraform-provider-artifactory/issues/1012)
PR: [#1019](https://github.com/jfrog/terraform-provider-artifactory/pull/1019)
* resource/artifactory_oauth_settings, resource/artifactory_saml_settings: Remove warning message about undocumented APIs. Issue: [#291](https://github.com/jfrog/terraform-provider-artifactory/issues/291) PR: [#1020](https://github.com/jfrog/terraform-provider-artifactory/pull/1020)

NOTES:

* resource/artifactory_artifactory_release_bundle_webhook: This resource is being deprecated and replaced by new `artifactory_destination_webhook` resource
* resource/artifactory_artifactory_release_bundle_custom_webhook: This resource is being deprecated and replaced by new `artifactory_destination_custom_webhook` resource

Issue: [#1012](https://github.com/jfrog/terraform-provider-artifactory/issues/1012)
PR: [#1019](https://github.com/jfrog/terraform-provider-artifactory/pull/1019)

## 11.1.0 (June 26, 2024). Tested on Artifactory 7.84.15 with Terraform 1.8.5 and OpenTofu 1.7.2

NOTES:
Expand Down
6 changes: 1 addition & 5 deletions pkg/artifactory/resource/configuration/resource_artifactory_oauth_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,11 +222,7 @@ func ResourceArtifactoryOauthSettings() *schema.Resource {
return packDiag
}

return diag.Diagnostics{{
Severity: diag.Warning,
Summary: "Usage of Undocumented Artifactory API Endpoints",
Detail: "The artifactory_oauth_settings resource uses endpoints that are undocumented and may not work with SaaS environments, or may change without notice.",
}}
return nil
}

var resourceOauthSettingsUpdate = func(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
Expand Down
6 changes: 1 addition & 5 deletions pkg/artifactory/resource/configuration/resource_artifactory_saml_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,7 @@ func resourceSamlSettingsRead(ctx context.Context, d *schema.ResourceData, m int
return packDiag
}

return diag.Diagnostics{{
Severity: diag.Warning,
Summary: "Usage of Undocumented Artifactory API Endpoints",
Detail: "The artifactory_saml_settings resource uses endpoints that are undocumented and may not work with SaaS environments, or may change without notice.",
}}
return nil
}

func resourceSamlSettingsUpdate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
Expand Down
Loading