Skip to content

Commit

Permalink
Fix state drift detection in acceptance test
Browse files Browse the repository at this point in the history
Update CHANGELOG with BREAKING CHANGES note
  • Loading branch information
alexhung committed Sep 13, 2024
1 parent 8fed84b commit d2d6ea7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## 12.0.0 (September 16, 2024)

BUG FIXES:
BREAKING CHANGES:

* resource/artifactory_remote_\*\_repository: Fix mismatch between documentation and actual default vaule for `list_remote_folder_items` attribute. PR: [#1072](https://github.com/jfrog/terraform-provider-artifactory/pull/1072)
* resource/artifactory_remote_\*\_repository: Fix mismatch between documentation and actual default vaule for `list_remote_folder_items` attribute. This will also match the change (default to `false`) introduced to the REST API in Artifactory v7.94.0. **Note:** Due to limitation of the Terraform SDKv2 framework, it is not possible to detect the attribute was not set and the state has the (previous) default value of `true`, then automaticaly upgrades it to `false`. Therefore this update will introduce state drift if this attribute is not set in your configuration. Use `terraform apply -refresh-only` to update your Terraform states to match. PR: [#1072](https://github.com/jfrog/terraform-provider-artifactory/pull/1072)

## 11.9.2 (September 12, 2024). Tested on Artifactory 7.90.10 with Terraform 1.9.5 and OpenTofu 1.8.2

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"testing"

"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/plancheck"
"github.com/hashicorp/terraform-plugin-testing/terraform"
"github.com/jfrog/terraform-provider-artifactory/v11/pkg/acctest"
"github.com/jfrog/terraform-provider-shared/testutil"
Expand Down Expand Up @@ -60,11 +59,8 @@ func TestAccRemoteRepositoryReplication_UpgradeFromSDKv2(t *testing.T) {
{
ProtoV6ProviderFactories: acctest.ProtoV6MuxProviderFactories,
Config: config,
ConfigPlanChecks: resource.ConfigPlanChecks{
PreApply: []plancheck.PlanCheck{
plancheck.ExpectEmptyPlan(),
},
},
PlanOnly: true,
ConfigPlanChecks: testutil.ConfigPlanChecks("artifactory_remote_repository_replication"),
},
},
})
Expand Down

0 comments on commit d2d6ea7

Please sign in to comment.