Prevent ComposedComponent from appearing before redirect#3
Open
pulsecat wants to merge 1 commit intojferrettiboke:masterfrom
Open
Prevent ComposedComponent from appearing before redirect#3pulsecat wants to merge 1 commit intojferrettiboke:masterfrom
pulsecat wants to merge 1 commit intojferrettiboke:masterfrom
Conversation
…r is unauthenticated
Owner
|
Hi @pulsecat. Thanks for your contribution. Can you show some test cases for this? This should not happen because |
Author
|
hi @jferrettiboke, It is what I observed on the client side. My React expertise isn't really good but I suspect that this.context.router.push('/') does not have immediate effect and the subsequent render occurred anyway. |
Owner
|
I didn't see anything that you mentioned. Can you explain me your use case exactly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a security issue when ComposedComponent appears for a second before redirect when the user is unauthenticated.