Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) #116

williamjohnstone · 2025-01-30T00:34:24Z

This PR is to introduce functionality for different keyboard mappings.

If you would like your mapping to be included in the initial PR, let me know and I will try my best.

Fixes #30

Store is functioning as expected, adding new layouts should be trivial and easily scalable. Implementation is different for each function that uses the keyboard (PasteModal vs Typing in the WebRTC window) these will all require their own testing.

Alters ActionBar.tsx to make the CTRL+ALT+DEL button in the Action Bar PR work again with layered with jetkvm#116 - not pulling into the PR until jetkvm#116 has been integrated, but the my PR will probably just be dropped anyway.

PrinceJunkie · 2025-02-01T10:40:32Z

Please include German Keyboard Layout

…ted settings.tsx to set the keyboard layout properly.

williamjohnstone · 2025-02-02T16:48:14Z

I have found further issues with the way that keyboard functionality is implemented, therefor the scope of work on this PR has been expanded.

I am working on this when I have time, thank you for everyone's continued patience.

williamjohnstone · 2025-02-02T16:53:06Z

This PR will now also resolve #125

…teModal to add more clarity to error message. Begin working on key remapping in WebRTC (working to a reasonable degree).

stylobille · 2025-02-03T13:05:28Z

Thank you for your help on this, I can test French keyboard if / when needed :)

… my changes (YAY!). Also spent 4 hours troubleshooting to find out I didn't realise how useCallback works... :/ Anway, not much longer before work on just the mappings can begin.

Rhaedyr · 2025-02-05T02:56:49Z

I know this may have been referenced, but I have a number of Hyprland systems I would love to use the JetKVM for but being able to use win/hyper key without the OS taking over would be immensely helpful, I would be happy to help test if you get to a testing phase, I might also be able to pitch in if I can find the time as well, Good Luck.

Adding an escape sequence in full screen to exit and send all keystrokes in fullscreen mode to the JetKVM might be a solution. say ctrl+alt+esc to exit fullscreen or the overlay exit button and use current system in windowed mode.

williamjohnstone · 2025-02-06T02:15:04Z

I know this may have been referenced, but I have a number of Hyprland systems I would love to use the JetKVM for but being able to use win/hyper key without the OS taking over would be immensely helpful, I would be happy to help test if you get to a testing phase, I might also be able to pitch in if I can find the time as well, Good Luck.

Adding an escape sequence in full screen to exit and send all keystrokes in fullscreen mode to the JetKVM might be a solution. say ctrl+alt+esc to exit fullscreen or the overlay exit button and use current system in windowed mode.

Yes, working on implementing the Keyboard Web API which should resolve this.

the problem is actually getting the browser to capture the keys, by default they are passed straight to the OS and the browser never sees them, which is why currently they don't function

craxo · 2025-02-06T11:06:12Z

Please add support for Norwegian Bokmål:
https://kbdlayout.info/KBDNO/

Alters ActionBar.tsx to make the CTRL+ALT+DEL button in the Action Bar PR work again with layered with jetkvm#116 - not pulling into the PR until jetkvm#116 has been integrated, but the my PR will probably just be dropped anyway.

CLAassistant · 2025-02-13T13:29:36Z

All committers have signed the CLA.

williamjohnstone · 2025-02-22T22:04:47Z

Just wanted to post an update, to let everyone know I haven't abandoned this, just difficult to find the time to work on it currently.

Nevexo · 2025-02-24T08:01:21Z

Just wanted to post an update, to let everyone know I haven't abandoned this, just difficult to find the time to work on it currently.

Never worry about this, we're all incredibly thankful for the time you do spend on it.
Thanks!

…dded functionality to disable keyboard mapping.

Nevexo · 2025-02-25T01:13:22Z

@Nevexo Can you pull these changes into the upcoming jetkvm-next release? I'm keen to get some people testing as I don't have access to different keyboards.

Will do, I'll get it out ASAP.

timothystewart6 · 2025-02-26T20:46:45Z

@williamjohnstone this does not seem to resolve #125 You mention it here in your comment but I have tested this branch on my own fork and it didn't seem to have any effect on capturing hotkeys. #116 (comment)

timothystewart6 · 2025-02-26T21:40:28Z

Hopped on a call with @williamjohnstone and tested everything.

TLDR; Everything works and it was most likely my cable (3rd party USB C to USB A cable, not the one that ships 🤦)

Properly captures Hotkeys (ctrl + ctrl 1-4 and long with ctrl + ctrl arrow keys)
Also tested meta keys.
- Using a mac and sending a commmand key sends the Windows Key
- Works in both fullscreen and non fullscreen
- Also works with key combos Windows + R opens run

Thank you!

…mplement proper modifer key holding.

netinto · 2025-03-04T15:05:51Z

Please support Korean Layout.

https://kbdlayout.info/kbdkor

toxic0berliner · 2025-03-07T20:45:24Z

Was going to start tinkering when I saw you already did all the hard work, 🙏 thanks 👍
Looking forward to seeing it merged

n-gerber · 2025-03-12T15:39:21Z

Thank you very much.
Please add support for the swiss german layout.
Looking forward for it.

williamjohnstone · 2025-03-13T19:54:49Z

I will not be adding any further keyboard layouts. Currently have UK, UK (Apple), US, German, and Spanish. It is too time consuming to add every layout and is taking time away from working on functionality. Therefor in the next week or so, I will complete the functionality of my changes, and finalise the Spanish layout. Then I will look to merge. The community can then add their own mappings as this is a trivial process.

I can assist in the mappings if people are having issues, but do not want to dedicate any more time to working on these mappings myself.

timothystewart6 · 2025-03-14T18:12:33Z

I agree. Once this is done it will provide a good pattern for adding more!

…gs to new settings page, update PasteModal to use new keyboard implemention, dropped spanish mappings.

williamjohnstone · 2025-04-12T16:14:38Z

A very short window of time opened up for me this weekend, so I have completed the following:

Dropped spanish mappings as they were time consuming to test
Dropped Modifier key holding (virtual keyboard) from this PR
Dropped addding keyboard mapping setup to initial JetKVM setup.
Merged changes with the latest dev branch

I have tested my changes as much as I can today, and briefly reviewed all my code. I believe the PR is now ready for reviewing/merging.

Any issues, let me know.

Thank you :)

Novido · 2025-04-14T09:31:01Z

Please add swedish support.
Thank you.

williamjohnstone · 2025-04-14T14:01:56Z

Please add swedish support. Thank you. @Novido

I will not be including any additional layouts in this PR.

williamjohnstone · 2025-04-16T20:34:29Z

@adamshiervani This is now ready for review

TerraD · 2025-04-30T15:35:22Z

I purchased 3 JetKVM, because they seemed the ideal way to access servers from everywhere – I even intended to purchase some more. However non working keyboard mappings are a dealbreaker!

The keyboard of my notebook is Swissgerman – it's layout is pretty far away from a US keyboard. In fact so far away that any real world usage is nearly impossible. And I can simply not carry a US English keyboard along every day only for that usage... In particular any process where passwords are needed will be practically impossible anyway: as I understand it, this would not even be solved if an US English keyboard would be plugged in. Who would be able to type in a strong password like 'xT<þRÒ%UºÜ|<HtDlïuÖ§Ò5K'`¹çY6º' by means of an US keyboard and the Alt-key?

I would gladly help to supply needed information and testing. However as this problem seems to exist for any non US keyboard I do think there needs to be a global solution that allows for adaptation of foreign keyboards without manual adaptation for each keyboard!

In my opinion this issue is not solved as long as we do not have a solution for all keyboards!

williamjohnstone · 2025-04-30T15:39:35Z

@TerraD As far as I know a global solution is not possible. PiKVM also uses keyboard mappings like in this PR. Adding keyboard layouts is trivial and somebody could easily spend time adding most used layouts, I just don't have the time.

toxic0berliner · 2025-04-30T15:48:05Z

Keep calm dude you bought into a Kickstarter and open source projet, comments like that feel entitled and are neither productive nor well received I believe.
Thanks William for the work I hope this gets reviewed quickly so other less talented people like myself can start scratching at it to add new and more layouts like FR for my use case 😉

stylobille · 2025-04-30T16:28:14Z

By the way could you explain somewhere how to add a mapping (if this hasn't been done already)? I would gladly help for french keyboards but I have no idea what to do and I'm not a dev, just an Ops. Le mer. 30 avr. 2025, 17:48, toxic0berliner ***@***.***> a écrit :

…

*toxic0berliner* left a comment (jetkvm/kvm#116) <#116 (comment)> Keep calm dude you bought into a Kickstarter and open source projet, comments like that feel entitled and are neither productive nor well received I believe. Thanks William for the work I hope this gets reviewed quickly so other less talented people like myself can start scratching at it to add new and more layouts like FR for my use case 😉 — Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEWMGLJC65IF6IOLUJWKKC324DWEZAVCNFSM6AAAAABWEC5Y4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBSGQ2DQNJXGU> . You are receiving this because you commented.Message ID: ***@***.***>

dlorch · 2025-04-30T16:37:52Z

@TerraD As far as I know a global solution is not possible. PiKVM also uses keyboard mappings like in this PR. Adding keyboard layouts is trivial and somebody could easily spend time adding most used layouts, I just don't have the time.

Hi @williamjohnstone, I am happy to volunteer as the contributor, maintainer and tester for the de-CH (Swiss German) keyboard layout. I was able to make frontend and make build_dev your code in my environment.

What's the best way to support? Should I create and provide a ui/src/keyboardMappings/layouts/de_CH.ts to you?

dlorch · 2025-04-30T16:40:10Z

@williamjohnstone apologies, I just saw your earlier note on:

I will not be including any additional layouts in this PR.

Then I will wait for your PR to be merged in an create a new PR for de-CH. Thanks for all your great work on this!

dlorch · 2025-04-30T20:25:09Z

ui/src/routes/devices.$id.settings.mouse.tsx

+                { value: "en-US", label: "US" },
+                { value: "en-GB", label: "UK" },
+                { value: "en-GB_apple", label: "UK (Apple)" },
+                { value: "de_DE", label: "German (T1)" },


I think this should be value: "de-DE" to match the value in ui/src/keyboardMappings/KeyboardLayouts.ts

dlorch · 2025-04-30T23:56:38Z

ui/src/keyboardMappings/KeyboardLayouts.ts

@@ -0,0 +1,218 @@
+import { keysUKApple, charsUKApple, modifiersUKApple } from './layouts/uk_apple';


Keys and modifiers correspond to definitions in the Linux USB HID gadget driver and are not language-dependent. These definitions could probably be factored out for easier maintenance.

williamjohnstone changed the title ~~[DRAFT] Early implementation of different keyboard layouts.~~ [DRAFT] Add functionality for multiple keyboard layouts Jan 30, 2025

Nevexo mentioned this pull request Jan 30, 2025

Cannot type characters with AltGr key #118

Closed

Nevexo added a commit to Nevexo/jetkvm-kvm that referenced this pull request Jan 30, 2025

NEXT-ONLY: Update README to introduce jetkvm#116

a3c9084

Nevexo mentioned this pull request Jan 30, 2025

JetKVM doesn't wake PC from sleep #120

Open

Move keyboardmapping store to stores.ts, simplified some things, upda…

7c40e2e

…ted settings.tsx to set the keyboard layout properly.

This was referenced Feb 2, 2025

multiKVM hotkey support #125

Open

Full screen should fully capture keyboard #127

Open

williamjohnstone changed the title ~~[DRAFT] Add functionality for multiple keyboard layouts~~ [DRAFT] Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) Feb 2, 2025

Fully implemented layout setting and switching in the UI. Updated Pas…

5f1e53f

…teModal to add more clarity to error message. Begin working on key remapping in WebRTC (working to a reasonable degree).

williamjohnstone added 2 commits February 4, 2025 01:45

Continued work on keyboard overhaul, found many more issues caused by…

f1de663

… my changes (YAY!). Also spent 4 hours troubleshooting to find out I didn't realise how useCallback works... :/ Anway, not much longer before work on just the mappings can begin.

Fix ghost keys issue, properly implemented modifer mapping

8732a6a

williamjohnstone mentioned this pull request Feb 11, 2025

Can't write/paste certain special characters using key combinations #30

Open

Nevexo added a commit to Nevexo/jetkvm-kvm that referenced this pull request Feb 11, 2025

NEXT-ONLY: Update README to introduce jetkvm#116

e847151

Nevexo added a commit to Nevexo/jetkvm-kvm that referenced this pull request Feb 11, 2025

NEXT-ONLY: Update README to introduce jetkvm#116

8c84441

Nevexo mentioned this pull request Feb 19, 2025

Spacebar pauses video stream in fullscreen mode #35

Open

Added German (T1) mappings, UK mappings, updated UK apple mappings. A…

40b1c70

…dded functionality to disable keyboard mapping.

Almost complete implementation of mapped virtual keyboard. Still to i…

fb3f5f4

…mplement proper modifer key holding.

williamjohnstone mentioned this pull request Feb 28, 2025

Mod key behaviour in virtual keyboard #211

Open

Nevexo mentioned this pull request Mar 4, 2025

Enable locale Virtual Keyboards (different languages) #223

Open

williamjohnstone added 3 commits April 11, 2025 13:26

Updated keyboard character codes, added half working spanish mappings

940612a

Merge remote-tracking branch 'upstream/dev' into keyboard-layouts

95c1410

Update macros to use new keyboard implementation, add keyboard settin…

e534450

…gs to new settings page, update PasteModal to use new keyboard implemention, dropped spanish mappings.

williamjohnstone changed the title ~~[DRAFT] Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality)~~ Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) Apr 12, 2025

Merge remote-tracking branch 'upstream/dev' into keyboard-layouts

f753a7a

williamjohnstone marked this pull request as ready for review April 12, 2025 16:11

williamjohnstone mentioned this pull request Apr 14, 2025

Not able to send "@" or "\" to the client #313

Open

dlorch reviewed Apr 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) #116

Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) #116

williamjohnstone commented Jan 30, 2025 •

edited

Loading

PrinceJunkie commented Feb 1, 2025 •

edited

Loading

williamjohnstone commented Feb 2, 2025 •

edited

Loading

williamjohnstone commented Feb 2, 2025 •

edited

Loading

stylobille commented Feb 3, 2025

Rhaedyr commented Feb 5, 2025

williamjohnstone commented Feb 6, 2025 •

edited

Loading

craxo commented Feb 6, 2025

CLAassistant commented Feb 13, 2025 •

edited

Loading

williamjohnstone commented Feb 22, 2025

Nevexo commented Feb 24, 2025

Nevexo commented Feb 25, 2025

timothystewart6 commented Feb 26, 2025 •

edited

Loading

timothystewart6 commented Feb 26, 2025

netinto commented Mar 4, 2025

toxic0berliner commented Mar 7, 2025

n-gerber commented Mar 12, 2025

williamjohnstone commented Mar 13, 2025

timothystewart6 commented Mar 14, 2025

williamjohnstone commented Apr 12, 2025

Novido commented Apr 14, 2025

williamjohnstone commented Apr 14, 2025

williamjohnstone commented Apr 16, 2025

TerraD commented Apr 30, 2025

williamjohnstone commented Apr 30, 2025

toxic0berliner commented Apr 30, 2025

stylobille commented Apr 30, 2025 via email

dlorch commented Apr 30, 2025

dlorch commented Apr 30, 2025

dlorch Apr 30, 2025

dlorch Apr 30, 2025

		@@ -0,0 +1,218 @@
		import { keysUKApple, charsUKApple, modifiersUKApple } from './layouts/uk_apple';

Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) #116

Are you sure you want to change the base?

Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) #116

Conversation

williamjohnstone commented Jan 30, 2025 • edited Loading

PrinceJunkie commented Feb 1, 2025 • edited Loading

williamjohnstone commented Feb 2, 2025 • edited Loading

williamjohnstone commented Feb 2, 2025 • edited Loading

stylobille commented Feb 3, 2025

Rhaedyr commented Feb 5, 2025

williamjohnstone commented Feb 6, 2025 • edited Loading

craxo commented Feb 6, 2025

CLAassistant commented Feb 13, 2025 • edited Loading

williamjohnstone commented Feb 22, 2025

Nevexo commented Feb 24, 2025

Nevexo commented Feb 25, 2025

timothystewart6 commented Feb 26, 2025 • edited Loading

timothystewart6 commented Feb 26, 2025

netinto commented Mar 4, 2025

toxic0berliner commented Mar 7, 2025

n-gerber commented Mar 12, 2025

williamjohnstone commented Mar 13, 2025

timothystewart6 commented Mar 14, 2025

williamjohnstone commented Apr 12, 2025

Novido commented Apr 14, 2025

williamjohnstone commented Apr 14, 2025

williamjohnstone commented Apr 16, 2025

TerraD commented Apr 30, 2025

williamjohnstone commented Apr 30, 2025

toxic0berliner commented Apr 30, 2025

stylobille commented Apr 30, 2025 via email

dlorch commented Apr 30, 2025

dlorch commented Apr 30, 2025

dlorch Apr 30, 2025

Choose a reason for hiding this comment

dlorch Apr 30, 2025

Choose a reason for hiding this comment

williamjohnstone commented Jan 30, 2025 •

edited

Loading

PrinceJunkie commented Feb 1, 2025 •

edited

Loading

williamjohnstone commented Feb 2, 2025 •

edited

Loading

williamjohnstone commented Feb 2, 2025 •

edited

Loading

williamjohnstone commented Feb 6, 2025 •

edited

Loading

CLAassistant commented Feb 13, 2025 •

edited

Loading

timothystewart6 commented Feb 26, 2025 •

edited

Loading