Skip to content

Conversation

@adamshiervani
Copy link
Contributor

Summary

  • Change default loglevel from INF to WARN in production as this could cause insanely large log files
  • Migrate old configurations

Checklist

  • Ran make test_e2e locally and passed
  • Linked to issue(s) above by issue number (e.g. Closes #<issue-number>)
  • One problem per PR (no unrelated changes)
  • Lints pass; CI green

@adamshiervani adamshiervani merged commit 3e7542a into dev Jan 7, 2026
3 checks passed
@adamshiervani adamshiervani deleted the fix/change-log-level branch January 7, 2026 12:32
loadedConfig.KeyboardLayout = "en-US"
}

// Migrate old verbose log level to sensible default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will effectively prevent people from selecting INFO won't it? Seems like this will run every boot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right. Luckily, the config is not exposed for the user yet, and I had to change the log level for all because users were getting insanely large logs files. One log I saw, was 100MB in 7 days.

Once we expose this configuration to people we can remove this line, as most users will be on 'WARN' in their configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants