Skip to content

Fix: Timeout Diagnostics #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamshiervani merged 4 commits into from
Jan 5, 2026
Merged

Fix: Timeout Diagnostics #1132

adamshiervani merged 4 commits into from
Jan 5, 2026

Conversation

@adamshiervani
Copy link
Contributor

@adamshiervani adamshiervani commented Jan 5, 2026

Summary

  • Use new API callJSONRPC methods
  • Implement timeouts out the diagnostic calls

Checklist

  • Ran make test_e2e locally and passed
  • Linked to issue(s) above by issue number (e.g. Closes #<issue-number>)
  • One problem per PR (no unrelated changes)
  • Lints pass; CI green
  • Tricky parts are commented in code

@adamshiervani
Enhance command execution with context timeout in diagnostics helper
acd8f02 
- Updated `runCmdLog` and `runShellLog` methods to use `exec.CommandContext` with a timeout, improving command execution reliability.
- Introduced a default command timeout constant to manage execution duration effectively.
@adamshiervani
Refactor diagnostics log retrieval to use async JSON-RPC calls
45cabe4 
- Replaced the synchronous JSON-RPC call in `FailSafeModeOverlay` and `SettingsAdvancedRoute` with an asynchronous approach using `callJsonRpc`.
- Improved error handling for diagnostics retrieval, ensuring user notifications are displayed for both success and failure cases.
- Updated the `rpcDataChannel` closure handling in `KvmIdRoute` to set the state correctly upon closure.
@adamshiervani
Fix lint
2b11fb9
@adamshiervani
Fix linter
a734f3e
@adamshiervani adamshiervani merged commit 81808b1 into dev Jan 5, 2026
3 checks passed
@adamshiervani adamshiervani deleted the fix/diagnostics branch January 5, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamshiervani