-
Notifications
You must be signed in to change notification settings - Fork 275
feat(ui): add always-visible ATX LED status indicators #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
IDisposable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI needs a localization pass
- Add ATXStateIndicator component to ActionBar - Show Power/HDD LED status when ATX extension is active - Add popover with Power/Reset buttons for quick access - Add confirmation dialogs for power actions to prevent accidents Note: Long-press support for force power off can be added in a future iteration - the backend already supports "power-long" action. Fixes jetkvm#729
|
Thanks for the thorough review @IDisposable! I've addressed all the comments. Please take a look when you get a chance. |
| } | ||
| // Close confirmation dialogs | ||
| setShowPowerConfirm(false); | ||
| setShowResetConfirm(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate line
| "paste_modal_failed_paste": "Failed to paste text: {error}", | ||
| "paste_modal_invalid_chars_intro": "The following characters won't be pasted:", | ||
| "paste_modal_paste_from_host": "Paste from host", | ||
| "paste_modal_password_mode": "Hide text (password mode)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated
Note: Long-press support for force power off can be added in a future iteration - the backend already supports "power-long" action.
Fixes #729