Skip to content

Conversation

@nitishagar
Copy link
Contributor

  • Add ATXStateIndicator component to ActionBar
  • Show Power/HDD LED status when ATX extension is active
  • Add popover with Power/Reset buttons for quick access
  • Add confirmation dialogs for power actions to prevent accidents

Note: Long-press support for force power off can be added in a future iteration - the backend already supports "power-long" action.

Fixes #729

Copy link
Contributor

@IDisposable IDisposable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI needs a localization pass

- Add ATXStateIndicator component to ActionBar
- Show Power/HDD LED status when ATX extension is active
- Add popover with Power/Reset buttons for quick access
- Add confirmation dialogs for power actions to prevent accidents

Note: Long-press support for force power off can be added in a future
iteration - the backend already supports "power-long" action.

Fixes jetkvm#729
@nitishagar
Copy link
Contributor Author

Thanks for the thorough review @IDisposable! I've addressed all the comments. Please take a look when you get a chance.

}
// Close confirmation dialogs
setShowPowerConfirm(false);
setShowResetConfirm(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line

"paste_modal_failed_paste": "Failed to paste text: {error}",
"paste_modal_invalid_chars_intro": "The following characters won't be pasted:",
"paste_modal_paste_from_host": "Paste from host",
"paste_modal_password_mode": "Hide text (password mode)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ATX LEDs always visible

2 participants