-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autopin dependencies #15559
fix: autopin dependencies #15559
Conversation
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks! mind signing the CLA?
36f9c6a
to
d65dba4
Compare
@SimenB it should be signed on our side. Not sure how to proceed else. |
Hmm, odd! Can you try to push an empty commit just to see if it triggers it to recheck or something? I tried to, but I'm not allowed to push to your fork (just EDIT: The force push 11 hours should have helped if new commit would, tho 🙁 |
I wonder if it's OK to merge regardless tho as it's not a code change per se, and not something that's distributed. @bensternthal would you know? Or, even better, know why the CLA says it's unsigned if it is? I tried clicking the "details" think from the status check, but that just takes me to a page where I can sign the CLA myself |
@SimenB you can always bypass CLA if you need to, however in this case @thypon should click the "Please click here to be authorized" link to see what it says. If this is a corporate CLA, there are a variety of reasons why this might fail. However if this is an individual, usually the only reason for failure is that the person has not agreed to the CLA. I can help diagnose when we have more information. |
whenever I try to sign as a corporation, it says that I should get the approval from the manager - that's me. If I go in the dashboard it looks already approved, and no extra requests are available. I can try to approve as an individual in case. The code is only CI anyway, and it can be obtained automatically with |
@thypon let me poke around on this and potentially file an issue for our IT folks to help. |
@thypon it looks like you have the signed corporate CLA but have not setup any approval criteria. Often companies set this to their corporate domain but you can also add users via email or via github username. More info can be found here. If you need help please feel free to reach out to me via slack or email. |
d65dba4
to
7feab86
Compare
Looks like it worked now, thanks! |
still missing something? @SimenB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
Summary
The sourcecode is functionally equivalent, and renovate will take care of updating these actions.
Context: threat actors exploiting github-actions supply-chain in the wild
Test plan
N/A