Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autopin dependencies #15559

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

thypon
Copy link
Contributor

@thypon thypon commented Apr 3, 2025

Summary

The sourcecode is functionally equivalent, and renovate will take care of updating these actions.

Context: threat actors exploiting github-actions supply-chain in the wild

Test plan

N/A

Copy link

linux-foundation-easycla bot commented Apr 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: thypon / name: Andrea (7feab86)

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7feab86
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/67f451076e445d00081807fd
😎 Deploy Preview https://deploy-preview-15559--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks! mind signing the CLA?

@thypon thypon force-pushed the fix/autopin-deps-20250403172151831 branch from 36f9c6a to d65dba4 Compare April 5, 2025 19:49
@thypon
Copy link
Contributor Author

thypon commented Apr 5, 2025

@SimenB it should be signed on our side. Not sure how to proceed else.

@SimenB SimenB closed this Apr 6, 2025
@SimenB SimenB reopened this Apr 6, 2025
@SimenB
Copy link
Member

SimenB commented Apr 6, 2025

Hmm, odd! Can you try to push an empty commit just to see if it triggers it to recheck or something? I tried to, but I'm not allowed to push to your fork

(just git commit -m 'trigger ci' --allow-empty)

EDIT: The force push 11 hours should have helped if new commit would, tho 🙁

@SimenB
Copy link
Member

SimenB commented Apr 6, 2025

I wonder if it's OK to merge regardless tho as it's not a code change per se, and not something that's distributed. @bensternthal would you know? Or, even better, know why the CLA says it's unsigned if it is? I tried clicking the "details" think from the status check, but that just takes me to a page where I can sign the CLA myself

@bensternthal
Copy link
Contributor

@SimenB you can always bypass CLA if you need to, however in this case @thypon should click the "Please click here to be authorized" link to see what it says.

If this is a corporate CLA, there are a variety of reasons why this might fail. However if this is an individual, usually the only reason for failure is that the person has not agreed to the CLA. I can help diagnose when we have more information.

@thypon
Copy link
Contributor Author

thypon commented Apr 7, 2025

whenever I try to sign as a corporation, it says that I should get the approval from the manager - that's me. If I go in the dashboard it looks already approved, and no extra requests are available. I can try to approve as an individual in case.

Screenshot 2025-04-07 at 11 19 17

The code is only CI anyway, and it can be obtained automatically with pinact, in case you want to do that way.
I'm fine closing this one as well if you want to do that on your side. Alternatively renovate can handle this automatically with the following config.

@bensternthal
Copy link
Contributor

@thypon let me poke around on this and potentially file an issue for our IT folks to help.

@bensternthal
Copy link
Contributor

@thypon it looks like you have the signed corporate CLA but have not setup any approval criteria. Often companies set this to their corporate domain but you can also add users via email or via github username. More info can be found here.

If you need help please feel free to reach out to me via slack or email.

@thypon thypon force-pushed the fix/autopin-deps-20250403172151831 branch from d65dba4 to 7feab86 Compare April 7, 2025 22:26
@thypon
Copy link
Contributor Author

thypon commented Apr 7, 2025

Looks like it worked now, thanks!

@thypon
Copy link
Contributor Author

thypon commented Apr 11, 2025

still missing something? @SimenB

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@SimenB SimenB merged commit f66b35e into jestjs:main Apr 11, 2025
86 checks passed
@thypon thypon deleted the fix/autopin-deps-20250403172151831 branch April 11, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants