Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest-snapshot): refactor Prettier related part #15546

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Mar 22, 2025

Summary

I noticed logic for Prettier 2 and 3 are not living together and seems there are differences (not touched in this PR).

Test plan

Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for jestjs failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 807cb3c
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/67e2bfc68380240008e99837

@JounQin
Copy link

JounQin commented Mar 23, 2025

Again, performance should be taken into account, synckit has better performance, TypeScript and native PnP support, etc.

For benchmark, see https://github.com/un-ts/synckit#benchmark

Sometimes even better: https://github.com/un-ts/synckit/actions/runs/14015583415/job/39240872165#step:7:1

@fisker
Copy link
Contributor Author

fisker commented Mar 25, 2025

Again, performance should be taken into account, synckit has better performance, TypeScript and native PnP support, etc.

For benchmark, see un-ts/synckit#benchmark

Sometimes even better: un-ts/synckit/actions/runs/14015583415/job/39240872165#step:7:1

[email protected] did have some places can improve communication between threads, but only the communication part, and it's done in v0.4. I don't want to argue with the performance problem here. If maintainers have questions, please take a look at https://github.com/fisker/make-synchronized-benchmark or test yourself.
I don't see a problem with TypeScript and native PnP support here.

@JounQin
Copy link

JounQin commented Mar 25, 2025

I don't see a problem with TypeScript and native PnP support here.

I found it could be that all jest test cases are run after building, so no .ts worker will be imported at that moment. For P'n'P, I don't know whether there is an e2e case for verifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants