Skip to content

Fix home and end keys in prompts #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefanhaller
Copy link
Collaborator

  • PR Description

In #4404 we added home/end support to confirmation popups. This broke handling of the home/end keys in prompts, where they used to work as alternatives to ctrl-a and ctrl-e.

Here's one way (maybe not the best) to fix this.

A better fix is probably to have separate views for confirmations and prompts, so that we can have different keybindings for each. That's a bit more work though.

Leaving as draft for now so that we can decide which approach we want.

Fixes #4553.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5d304091 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5d30409) Report Missing Report Missing Report Missing
Head commit (b040abd) 56358 48937 86.83%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4554) 2 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home and End keys no longer work in input dialog
1 participant