This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Remove normalization option in constructor in favor of normalizing in toString
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix the description of how normalization is handled.
jessealama
deleted the
71-remove-normalization-option-to-constructor-in-favor-of-normalizing-in-tostring
branch
jessealama
added a commit
to jessealama/proposal-decimal
that referenced
this pull request
Jan 31, 2024
This method can be reproduced in userland by calling the Decimal128 constructor with the results of `toString`. This mirrors the change made in jessealama/decimal128#72 .
jessealama
added a commit
to tc39/proposal-decimal
that referenced
this pull request
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, clean up README and restore (rounding) options to arithmetic operations.