Fixed Bugged Leaky Reset Mechanisms#379
Open
DoubleGio wants to merge 2 commits intojeshraghian:masterfrom
Open
Fixed Bugged Leaky Reset Mechanisms#379DoubleGio wants to merge 2 commits intojeshraghian:masterfrom
DoubleGio wants to merge 2 commits intojeshraghian:masterfrom
Conversation
DoubleGio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reset mechanisms in the Leaky class got broken in version 0.08 where they got refactored a bit.
Both soft and hard reset mechanisms do not function as expected: currently the default soft reset resets to zero, whereas the hard reset resets by subtraction -- see this open issue, or you may see for yourself by running tutorial 3 with the current release of snntorch (0.9.4).
With this fix you get the proper behaviour:
