Fix spike/membrane potential independence#368
Open
leoauri wants to merge 7 commits intojeshraghian:noisy_leakyfrom
Open
Fix spike/membrane potential independence#368leoauri wants to merge 7 commits intojeshraghian:noisy_leakyfrom
leoauri wants to merge 7 commits intojeshraghian:noisy_leakyfrom
Conversation
Author
|
Fixes #366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a way that
NoisyLeakycan work, resetting the membrane potential if and only if the neuron spikes.Demo:
That seems to make more sense to me.
I decided to change the mem output to reflect the value after spike/membrane reset in that step. Otherwise, I would have had to either make the class stateful or change the interface. Also, this just makes more sense to my brain. How does that play with the rest of the SNN world?
Cheers,
Leo