-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --prometheus_addr
command line parameter
#1608
Conversation
20d4f4e
to
e412fa6
Compare
This commit adds support for the `--prometheus_addr` command line parameter to allow binding the Prometheus metrics server on a different host address.
e412fa6
to
b33930a
Compare
Kubernetes typically handles the services on its own, so we'll skip adding the address param to the Helm chart. Since there are no existing tests for the prometheus port we'll skip that as well. |
Do you know if there is an existing way to set up |
In the docs it shows how to run a local environment directly with Python. I suggest creating a virtual environment (venv) first to avoid collisions with other Python apps. |
@jertel I manage to test my changes locally by hand using the following steps:
|
@jertel Thank you for reviewing |
This commit adds support for the
--prometheus_addr
command lineparameter to allow binding the Prometheus metrics server on a different
host address.
Reviewer notes
I'm not quite sure how to do this so would like to get some help here if possible.