Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Powerautomate] Add size text sumary and body #1513

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

marssilva
Copy link
Contributor

@marssilva marssilva commented Aug 5, 2024

Description

Adding the feature that adjusts the size of the summary and body in the ms_power_automate alert.

Checklist

Created two tests for new feature and adjusted documentation.

  • I have reviewed the contributing guidelines.
  • [x ] I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

@marssilva
Copy link
Contributor Author

Hi @jertel, I made some adjustments to the size of the summary and the body of the text, in "teams" the summary doesn't show everything when the text is long.

@jertel
Copy link
Owner

jertel commented Aug 5, 2024

Thanks for submitting this. Can you adjust the schema to use enums for those new values. Ex:

telegram_parse_mode: {type: string, enum: ['markdown', 'markdownV2', 'html']}

Also, please add this PR to the changelog. You can either add the second PR hyperlink to your existing entry, or create a new entry.

@marssilva
Copy link
Contributor Author

Suggestions applied @jertel.

@jertel jertel merged commit a2900e7 into jertel:master Aug 6, 2024
1 check passed
@marssilva marssilva deleted the powerautomate branch August 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants