Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workwechat msgtype #1369

Merged
merged 6 commits into from
Mar 28, 2024
Merged

add workwechat msgtype #1369

merged 6 commits into from
Mar 28, 2024

Conversation

bitqiu
Copy link
Contributor

@bitqiu bitqiu commented Feb 2, 2024

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
Copy link
Collaborator

Please add this line to the New features section at the top of CHANGELOG.md:

- [workwechat] add workwechat msgtype - [#1369](https://github.com/jertel/elastalert2/pull/1369) - @bitqiu

@bitqiu
Copy link
Contributor Author

bitqiu commented Feb 2, 2024

Please add this line to the New features section at the top of CHANGELOG.md:

- [workwechat] add workwechat msgtype - [#1369](https://github.com/jertel/elastalert2/pull/1369) - @bitqiu

already done

@nsano-rururu
Copy link
Collaborator

I apologize for the lack of explanation. Please add it below what is currently listed.

current

- [workwechat] add workwechat msgtype - [#1369](https://github.com/jertel/elastalert2/pull/1369) - @bitqiu
- Add workwechat alerter - [#1367](https://github.com/jertel/elastalert2/pull/1367) - @wufeiqun

fix

- Add workwechat alerter - [#1367](https://github.com/jertel/elastalert2/pull/1367) - @wufeiqun
- [workwechat] add workwechat msgtype - [#1369](https://github.com/jertel/elastalert2/pull/1369) - @bitqiu

@bitqiu
Copy link
Contributor Author

bitqiu commented Feb 2, 2024

already done

@nsano-rururu
Copy link
Collaborator

Has test code been added when work_wechat_msgtype is set to markdown?

@@ -795,6 +795,7 @@ properties:

### WorkWechat
work_wechat_bot_id: { type: string }
work_wechat_msgtype: { type: string }
Copy link
Collaborator

@nsano-rururu nsano-rururu Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a value other than text or markdown is specified for work_wechat_msgtype in the pyyaml validation check, an exception will occur when the rule is executed.

work_wechat_msgtype: { type: string }

to

work_wechat_msgtype: {type: string, enum: ['text', 'markdown']}

Copy link

github-actions bot commented Mar 7, 2024

This PR is stale because it has been open for 30 days with no activity. The longer a PR remains stale the more out of date with the main branch it becomes.

@github-actions github-actions bot added the Stale label Mar 7, 2024
@nsano-rururu
Copy link
Collaborator

@jertel
I think this pull request can be merged. I don't think there are any particular problems with the functionality or test code.

jertel
jertel previously approved these changes Mar 28, 2024
@jertel jertel merged commit f8397a6 into jertel:master Mar 28, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants