Skip to content

Conversation

lmbringas
Copy link
Contributor

@lmbringas lmbringas commented Feb 24, 2019

Hi, I've just add save track option and i changed suggested_key of shuffle to Alt+Shift+S because i think that is more intuitive now.
I attached how i see the save icon

imagen

@jerosa
Copy link
Owner

jerosa commented Feb 26, 2019

Hi. The default hotkey for shuffle is not "Alt+Shift+S" due to Firefox using that keystroke for opening the History navbar, at least in Firefox Developer Edition.

As for adding the option to save the song, I have to make some changes in the configuration but I will implement it. Thanks

@jerosa
Copy link
Owner

jerosa commented Feb 26, 2019

Hi again. I was checking the correct behaviour of the new feature, but I doesn't work for me.
Looking at the Spotify web source code, the class .spoticon-add-16 wasn't there. Instead I found .spoticon-fav-16.

Can you please tell me from what url are you accessing the site?

@lmbringas
Copy link
Contributor Author

lmbringas commented Feb 27, 2019

hi, this is url https://open.spotify.com/browse/featured. I'm using Mozilla Firefox 65.0 and this is how i see the website.

imagen

@jerosa
Copy link
Owner

jerosa commented Feb 28, 2019

Kinda strange. I'm going to make some changes so that it works for us both. Once I have the new version I would ask you if it is possible for you to do some tests since I can not do it myself.

@lmbringas
Copy link
Contributor Author

hey, you should check this PR. They have same issue but with different types of icons.
Yes I'll test. thanks

@jerosa
Copy link
Owner

jerosa commented Feb 28, 2019

Added a query to check if spoticon-heartis present, if not use .spoticon-add.

Now it should work. Please try it and let me know before deploying the new version.

@lmbringas
Copy link
Contributor Author

hey thanks. check that you added twice document.querySelector('.spoticon-add-16') but one has to be document.querySelector('.spoticon-added-16'). if you change that it will work excellent.

@jerosa
Copy link
Owner

jerosa commented Mar 4, 2019

I'm going to upload the new version to firefox so in the next update this feature will be implemented.
Thank you for your contribution and the testing.

@jerosa jerosa merged commit 68f822d into jerosa:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants