-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch chap tui to a multiline text field #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to technical limitations in textual there's no way to handle ctrl-enter (terminal emulator limitation) or alt-enter (textual limitation) so the submit key becomes F9. it'd be nice someday to switch between single-line and multiline entry but not right now.
turns out I have some systems where I care about that :)
this made it necessary to plumb 'ctx' through some additional places, all to make it easy to call BoolParamType().convert().
this is faster enough that it's a huge qol win
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to technical limitations in textual there's no way to handle ctrl-enter (terminal emulator limitation) or alt-enter (textual limitation) so the submit key becomes F9.
it'd be nice someday to switch between single-line and multiline entry but not right now.