feat($point): New point parameter for LineChart
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `point` parameter for modifying color, opacity radius and stroke props on rendered SVG
jens-ox
requested changes
Apr 22, 2020
| @@ -80,6 +83,7 @@ export default class AbstractChart { | |||
| * @param {Function} [tooltipFunction] function that receives a data object and returns the string displayed as tooltip. | |||
| * @param {Array} [legend] names of the sub-arrays of data, used as legend labels. | |||
| * @param {String | Object} [legendTarget] DOM node to which the legend should be mounted. | |||
| * @param {Object} [point={ color: null, radius: 3, fillOpacity: 1, strokeWidth: 0, strokeColor: null }] point object specifying color, radius, fillOpacity, strokeWidth and strokeColor. | |||
There was a problem hiding this comment.
This can be split up to multiple lines, see https://github.com/documentationjs/documentation/blob/master/docs/RECIPES.md#destructuring-parameters
Comment on lines
+40
to
+44
| radius: this.point.radius || 3, | ||
| color: this.point.color || this.colors[index], | ||
| fillOpacity: this.point.fillOpacity, | ||
| strokeWidth: this.point.strokeWidth, | ||
| strokeColor: this.point.strokeColor |
Comment on lines
+122
to
+125
| const color = this.point.color || this.colors[index] | ||
| const fillOpacity = this.point.fillOpacity | ||
| const strokeWidth = this.point.strokeWidth | ||
| const strokeColor = this.point.strokeColor |
|
Also, rebasing to master should fix the build issues from Netlify 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
pointparameter for modifying color, opacity radius and stroke props on rendered SVG rather than using CSS-based modifiers.