Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spotbugs 4.8.2 #324

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

MarkEWaite
Copy link
Contributor

Use spotbugs 4.8.2

Suppress an unread field warning to retain compatibility.

Initialize strategy to avoid spotbugs warning

No evidence of any detected bug, but initializing a field in the constructor seems reasonable, especially since it is using the value that is assigned in the init() method.

Testing done

Automated tests pass and the code is covered by the automated tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

No evidence of any detected bug, but initializing a field in the
constructor seems reasonable, especially since it is using the value
that is assigned in the init() method.

Automated tests pass and the code is covered by the automated tests.
Suppress an unread field warning to retain compatibility
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 21, 2023 15:11
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Dec 21, 2023
@github-actions github-actions bot added the dependencies Dependency related change label Dec 21, 2023
@MarkEWaite MarkEWaite merged commit 43a1b58 into jenkinsci:master Dec 21, 2023
17 checks passed
@MarkEWaite MarkEWaite deleted the use-spotbugs-4.8.2 branch December 21, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users dependencies Dependency related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant